Merge pull request #67 from RNA4219/codex/add-validation-for-pr-body-requirements

Enforce PR body requirements in governance gate

Author: RNA4219

tests/test_check_governance_gate.py

@@ -8,7 +8,7 @@
 from tools.ci.check_governance_gate import (
     find_forbidden_matches,
     load_forbidden_patterns,
-    validate_priority_score,
+    validate_pr_body,
 )
 
 
@@ -29,22 +29,49 @@ def test_find_forbidden_matches(changed_paths, patterns, expected):
     assert find_forbidden_matches(changed_paths, normalized) == expected
 
 
-@pytest.mark.parametrize(
-    "body",
-    [
-        "Priority Score: 5 / 安全性強化",
-        "Priority Score: 1 / 即応性向上",
-        "Priority Score: 3",
-        "Priority Score: / 理由",
-        "Priority Score: abc / 理由",
-        "Priority Score: <!-- 例: 5 / prioritization.yaml#phase1 -->",
-        "priority score: 3",
-        "",
-        None,
-    ],
-)
-def test_validate_priority_score_is_now_noop(body):
-    assert validate_priority_score(body) is True
+def test_validate_pr_body_success(capsys):
+    body = """
+Intent: INT-123
+## EVALUATION
+Priority Score: 4.5 / 安全性強化
+"""
+
+    assert validate_pr_body(body) is True
+    captured = capsys.readouterr()
+    assert captured.err == ""
+
+
+def test_validate_pr_body_missing_intent(capsys):
+    body = """
+## EVALUATION
+Priority Score: 2
+"""
+
+    assert validate_pr_body(body) is False
+    captured = capsys.readouterr()
+    assert "PR body must include 'Intent: INT-xxx'" in captured.err
+
+
+def test_validate_pr_body_missing_evaluation(capsys):
+    body = """
+Intent: INT-001
+Priority Score: 3
+"""
+
+    assert validate_pr_body(body) is False
+    captured = capsys.readouterr()
+    assert "PR must reference EVALUATION" in captured.err
+
+
+def test_validate_pr_body_warns_without_priority_score(capsys):
+    body = """
+Intent: INT-789
+## EVALUATION
+"""
+
+    assert validate_pr_body(body) is True
+    captured = capsys.readouterr()
+    assert "Consider adding 'Priority Score: <number>'" in captured.err
 
 
 def test_load_forbidden_patterns(tmp_path):

tools/ci/check_governance_gate.py

@@ -2,6 +2,7 @@
 
 import json
 import os
+import re
 import subprocess
 import sys
 from fnmatch import fnmatch
@@ -85,8 +86,28 @@ def read_event_body(event_path: Path) -> str | None:
     return body
 
 
-def validate_priority_score(body: str | None) -> bool:
-    return True
+INTENT_PATTERN = re.compile(r"Intent:\s*INT-\d+", re.IGNORECASE)
+EVALUATION_PATTERN = re.compile(r"EVALUATION", re.IGNORECASE)
+PRIORITY_PATTERN = re.compile(r"Priority\s*Score\s*:\s*\d+(?:\.\d+)?", re.IGNORECASE)
+
+
+def validate_pr_body(body: str | None) -> bool:
+    normalized_body = body or ""
+    success = True
+
+    if not INTENT_PATTERN.search(normalized_body):
+        print("PR body must include 'Intent: INT-xxx'", file=sys.stderr)
+        success = False
+    if not EVALUATION_PATTERN.search(normalized_body):
+        print("PR must reference EVALUATION (acceptance) anchor", file=sys.stderr)
+        success = False
+    if not PRIORITY_PATTERN.search(normalized_body):
+        print(
+            "Consider adding 'Priority Score: <number>' based on prioritization.yaml",
+            file=sys.stderr,
+        )
+
+    return success
 
 
 def main() -> int:
@@ -112,7 +133,8 @@ def main() -> int:
         print("GITHUB_EVENT_PATH is not set", file=sys.stderr)
         return 1
     body = read_event_body(Path(event_path_value))
-    validate_priority_score(body)
+    if not validate_pr_body(body):
+        return 1
 
     return 0