feat(router): output server$ errors to server log

Author: wmertens

.changeset/gentle-laws-see.md

@@ -0,0 +1,5 @@
+---
+'@qwik.dev/router': minor
+---
+
+FEAT: if a server$ function throws an error that is not a `ServerError`, it will now log the error on the server

packages/qwik-router/src/middleware/request-handler/resolve-request-handlers.ts

@@ -339,18 +339,18 @@ function isAsyncIterator(obj: unknown): obj is AsyncIterable<unknown> {
 }
 
 async function runServerFunction(ev: RequestEvent) {
-  const fn = ev.query.get(QFN_KEY);
+  const serverFnHash = ev.query.get(QFN_KEY);
   if (
-    fn &&
-    ev.request.headers.get('X-QRL') === fn &&
+    serverFnHash &&
+    ev.request.headers.get('X-QRL') === serverFnHash &&
     ev.request.headers.get('Content-Type') === 'application/qwik-json'
   ) {
     ev.exit();
     const isDev = getRequestMode(ev) === 'dev';
     const data = await ev.parseBody();
     if (Array.isArray(data)) {
       const [qrl, ...args] = data;
-      if (isQrl(qrl) && qrl.getHash() === fn) {
+      if (isQrl(qrl) && qrl.getHash() === serverFnHash) {
         let result: unknown;
         try {
           if (isDev) {
@@ -364,6 +364,7 @@ async function runServerFunction(ev: RequestEvent) {
           if (err instanceof ServerError) {
             throw ev.error(err.status as ErrorCodes, err.data);
           }
+          console.error(`Server function ${serverFnHash} failed:`, err);
           throw ev.error(500, 'Invalid request');
         }
         if (isAsyncIterator(result)) {