Skip to content

Commit 9d212ee

Browse files
committed
fix(ci): enable eslint in starters
1 parent 792db96 commit 9d212ee

File tree

7 files changed

+8
-4
lines changed

7 files changed

+8
-4
lines changed

eslint.config.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,22 +30,26 @@ const ignores = [
3030
'packages/docs/src/routes/examples/apps',
3131
'packages/docs/src/routes/playground/app',
3232
'packages/docs/src/routes/tutorial',
33+
'packages/qwik/src/optimizer/core/src/fixtures',
34+
'packages/qwik/bindings',
3335
'packages/qwik-labs/lib',
3436
'packages/qwik-labs/lib-types',
3537
'packages/qwik-labs/vite',
3638
'packages/insights/drizzle.config.ts',
3739
'packages/insights/panda.config.ts',
40+
'packages/qwik/src/napi',
3841
'starters/apps/base',
3942
'starters/apps/library',
4043
'starters/templates',
4144
'**/vite.config.ts',
4245
// packages with eslint.config.mjs
4346
'packages/qwik-labs',
4447
'packages/insights',
45-
'starters',
4648
// eslint.config.*
4749
'**/eslint.config.mjs',
4850
'**/eslint.config.js',
51+
'.changeset',
52+
'packages/docs/public/builder',
4953
];
5054

5155
export default tseslint.config(

packages/qwik/src/qwikloader.unit.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ test('qwikloader script', () => {
2929
`);
3030

3131
expect(qwikLoader).toMatchInlineSnapshot(
32-
//eslint-disable-next-line
3332
`"const t=document,e=window,n=new Set,o=new Set([t]);let r;const s=(t,e)=>Array.from(t.querySelectorAll(e)),a=t=>{const e=[];return o.forEach(n=>e.push(...s(n,t))),e},i=t=>{w(t),s(t,"[q\\\\:shadowroot]").forEach(t=>{const e=t.shadowRoot;e&&i(e)})},c=t=>t&&"function"==typeof t.then,l=(t,e,n=e.type)=>{a("[on"+t+"\\\\:"+n+"]").forEach(o=>{b(o,t,e,n)})},f=e=>{if(void 0===e._qwikjson_){let n=(e===t.documentElement?t.body:e).lastElementChild;for(;n;){if("SCRIPT"===n.tagName&&"qwik/json"===n.getAttribute("type")){e._qwikjson_=JSON.parse(n.textContent.replace(/\\\\x3C(\\/?script)/gi,"<$1"));break}n=n.previousElementSibling}}},p=(t,e)=>new CustomEvent(t,{detail:e}),b=async(e,n,o,r=o.type)=>{const s="on"+n+":"+r;e.hasAttribute("preventdefault:"+r)&&o.preventDefault(),e.hasAttribute("stoppropagation:"+r)&&o.stopPropagation();const a=e._qc_,i=a&&a.li.filter(t=>t[0]===s);if(i&&i.length>0){for(const t of i){const n=t[1].getFn([e,o],()=>e.isConnected)(o,e),r=o.cancelBubble;c(n)&&await n,r&&o.stopPropagation()}return}const l=e.getAttribute(s);if(l){const n=e.closest("[q\\\\:container]"),r=n.getAttribute("q:base"),s=n.getAttribute("q:version")||"unknown",a=n.getAttribute("q:manifest-hash")||"dev",i=new URL(r,t.baseURI);for(const p of l.split("\\n")){const l=new URL(p,i),b=l.href,h=l.hash.replace(/^#?([^?[|]*).*$/,"$1")||"default",q=performance.now();let _,d,y;const w=p.startsWith("#"),g={qBase:r,qManifest:a,qVersion:s,href:b,symbol:h,element:e,reqTime:q};if(w){const e=n.getAttribute("q:instance");_=(t["qFuncs_"+e]||[])[Number.parseInt(h)],_||(d="sync",y=Error("sym:"+h))}else{u("qsymbol",g);const t=l.href.split("#")[0];try{const e=import(t);f(n),_=(await e)[h],_||(d="no-symbol",y=Error(\`\${h} not in \${t}\`))}catch(t){d||(d="async"),y=t}}if(!_){u("qerror",{importError:d,error:y,...g}),console.error(y);break}const m=t.__q_context__;if(e.isConnected)try{t.__q_context__=[e,o,l];const n=_(o,e);c(n)&&await n}catch(t){u("qerror",{error:t,...g})}finally{t.__q_context__=m}}}},u=(e,n)=>{t.dispatchEvent(p(e,n))},h=t=>t.replace(/([A-Z])/g,t=>"-"+t.toLowerCase()),q=async t=>{let e=h(t.type),n=t.target;for(l("-document",t,e);n&&n.getAttribute;){const o=b(n,"",t,e);let r=t.cancelBubble;c(o)&&await o,r||(r=r||t.cancelBubble||n.hasAttribute("stoppropagation:"+t.type)),n=t.bubbles&&!0!==r?n.parentElement:null}},_=t=>{l("-window",t,h(t.type))},d=()=>{const s=t.readyState;if(!r&&("interactive"==s||"complete"==s)&&(o.forEach(i),r=1,u("qinit"),(e.requestIdleCallback??e.setTimeout).bind(e)(()=>u("qidle")),n.has("qvisible"))){const t=a("[on\\\\:qvisible]"),e=new IntersectionObserver(t=>{for(const n of t)n.isIntersecting&&(e.unobserve(n.target),b(n.target,"",p("qvisible",n)))});t.forEach(t=>e.observe(t))}},y=(t,e,n,o=!1)=>{t.addEventListener(e,n,{capture:o,passive:!1})},w=(...t)=>{for(const r of t)"string"==typeof r?n.has(r)||(o.forEach(t=>y(t,r,q,!0)),y(e,r,_,!0),n.add(r)):o.has(r)||(n.forEach(t=>y(r,t,q,!0)),o.add(r))};if(!("__q_context__"in t)){t.__q_context__=0;const r=e.qwikevents;r&&(Array.isArray(r)?w(...r):w("click","input")),e.qwikevents={events:n,roots:o,push:w},y(t,"readystatechange",d),d()}"`
3433
);
3534
});

starters/apps/playground/src/routes/demo/flower/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ export default component$(() => {
1616
number: 20,
1717
});
1818

19-
// eslint-disable-next-line qwik/no-use-visible-task
2019
useVisibleTask$(({ cleanup }) => {
2120
const timeout = setTimeout(() => (state.count = 1), 500);
2221
cleanup(() => clearTimeout(timeout));

starters/apps/preloader-test/src/components/generated/show-dynamic.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ export default component$(() => {
88
<button
99
onClick$={() => {
1010
showDynamic.value = true;
11+
// eslint-disable-next-line no-console
1112
console.log(
1213
`
1314
************************************************

starters/apps/preloader-test/src/routes/counters/index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,7 @@ export default component$(() => {
215215
<Counter100 />
216216
<Link
217217
href="/hidden"
218+
// eslint-disable-next-line no-console
218219
onQVisible$={() => console.log("visible below fold")}
219220
>
220221
Home

starters/apps/preloader-test/src/routes/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable no-console */
21
import {
32
component$,
43
useTask$,

starters/apps/preloader-test/src/routes/layout.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ export default component$(() => {
6969
<LinkCmp href="/about">About</LinkCmp>
7070
<LinkCmp
7171
href="/counters"
72+
// eslint-disable-next-line no-console
7273
onQVisible$={() => console.log("visible")}
7374
>
7475
Counters

0 commit comments

Comments
 (0)