chore: update package.json files to use "module" type and remove globalThis.IS_ESM references

Author: JerryWu1234

e2e/docs-e2e/package.json

@@ -14,5 +14,5 @@
     "test": "pnpm exec playwright test --config=playwright.config.ts --project=chromium",
     "test-ui": "pnpm exec playwright test --config=playwright.config.ts --project=chromium --ui"
   },
-  "type": "commonjs"
+  "type": "module"
 }

e2e/qwik-cli-e2e/package.json

@@ -8,5 +8,6 @@
   "scripts": {
     "e2e": "vitest run --config=vite.config.ts",
     "e2e.watch": "vitest watch --config=vite.config.ts"
-  }
+  },
+  "type": "module"
 }

packages/qwik/src/optimizer/src/platform.ts

@@ -29,9 +29,7 @@ export async function getSystem() {
 
   sys.path = createPath(sys);
 
-  if (globalThis.IS_ESM) {
-    sys.strictDynamicImport = sys.dynamicImport = (path) => import(path);
-  }
+  sys.strictDynamicImport = sys.dynamicImport = (path) => import(path);
 
   if (sysEnv !== 'webworker' && sysEnv !== 'browsermain') {
     try {
@@ -119,14 +117,10 @@ export async function loadPlatformBinding(sys: OptimizerSystem) {
         for (const triple of triples) {
           // Node.js - Native Binding
           try {
-            if (globalThis.IS_ESM) {
-              const module = await sys.dynamicImport('node:module');
-              const mod = module.default.createRequire(import.meta.url)(
-                `../bindings/${triple.platformArchABI}`
-              );
-              return mod;
-            }
-            const mod = await sys.dynamicImport(`../bindings/${triple.platformArchABI}`);
+            const module = await sys.dynamicImport('node:module');
+            const mod = module.default.createRequire(import.meta.url)(
+              `../bindings/${triple.platformArchABI}`
+            );
             return mod;
           } catch (e) {
             console.warn(
@@ -139,24 +133,22 @@ export async function loadPlatformBinding(sys: OptimizerSystem) {
     }
   }
 
-  if (globalThis.IS_ESM) {
-    if (sysEnv === 'node' || sysEnv === 'bun') {
-      // ESM WASM Node.js
-      const url: typeof import('url') = await sys.dynamicImport('node:url');
-      const __dirname = sys.path.dirname(url.fileURLToPath(import.meta.url));
-      const wasmPath = sys.path.join(__dirname, '..', 'bindings', 'qwik_wasm_bg.wasm');
-      const mod = await sys.dynamicImport(`../bindings/qwik.wasm.mjs`);
-      const fs: typeof import('fs') = await sys.dynamicImport('node:fs');
-
-      const buf = await fs.promises.readFile(wasmPath);
-      const wasm = await WebAssembly.compile(buf as any);
-      await mod.default(wasm);
-      return mod;
-    } else {
-      const module = await sys.dynamicImport(`../bindings/qwik.wasm.mjs`);
-      await module.default();
-      return module;
-    }
+  if (sysEnv === 'node' || sysEnv === 'bun') {
+    // ESM WASM Node.js
+    const url: typeof import('url') = await sys.dynamicImport('node:url');
+    const __dirname = sys.path.dirname(url.fileURLToPath(import.meta.url));
+    const wasmPath = sys.path.join(__dirname, '..', 'bindings', 'qwik_wasm_bg.wasm');
+    const mod = await sys.dynamicImport(`../bindings/qwik.wasm.mjs`);
+    const fs: typeof import('fs') = await sys.dynamicImport('node:fs');
+
+    const buf = await fs.promises.readFile(wasmPath);
+    const wasm = await WebAssembly.compile(buf as any);
+    await mod.default(wasm);
+    return mod;
+  } else {
+    const module = await sys.dynamicImport(`../bindings/qwik.wasm.mjs`);
+    await module.default();
+    return module;
   }
 
   throw new Error(`Platform not supported`);
@@ -218,7 +210,6 @@ const extensions: { [ext: string]: boolean } = {
   '.mjs': true,
 };
 
-declare const globalThis: { IS_ESM: boolean; [key: string]: any };
 declare const WorkerGlobalScope: any;
 declare const Deno: any;
 declare const Bun: any;

scripts/submodule-optimizer.ts

@@ -73,7 +73,6 @@ export async function submoduleOptimizer(config: BuildConfig) {
     },
     define: {
       ...commonConfig.define,
-      'globalThis.IS_ESM': 'true',
     },
   };
 

scripts/submodule-server.ts

@@ -76,7 +76,6 @@ export async function submoduleServer(config: BuildConfig) {
     define: {
       ...(await inlineQwikScriptsEsBuild(config)),
       ...(await inlineBackpatchScriptsEsBuild(config)),
-      'globalThis.IS_ESM': 'true',
       'globalThis.QWIK_VERSION': JSON.stringify(config.distVersion),
       'globalThis.QWIK_DOM_VERSION': JSON.stringify(qwikDomVersion),
     },

starters/adapters/aws-lambda/package.json

@@ -19,5 +19,6 @@
       "https://aws.amazon.com/es/lambda/",
       "https://www.serverless.com/cloud/docs/get-started"
     ]
-  }
+  },
+  "type": "module"
 }

starters/adapters/azure-swa/package.json

@@ -24,5 +24,6 @@
         "- pnpm run deploy: it will use the SWA CLI to deploy your site"
       ]
     }
-  }
+  },
+  "type": "module"
 }

starters/adapters/bun/package.json

@@ -23,5 +23,6 @@
   },
   "devDependencies": {
     "@types/bun": "*"
-  }
+  },
+  "type": "module"
 }

starters/adapters/cloud-run/package.json

@@ -20,5 +20,6 @@
         "- pnpm run deploy: it will use the gcloud CLI to deploy your site"
       ]
     }
-  }
+  },
+  "type": "module"
 }

starters/adapters/cloudflare-pages/package.json

@@ -24,5 +24,6 @@
         "- pnpm run deploy: it will use the Cloudflare CLI to deploy your site"
       ]
     }
-  }
+  },
+  "type": "module"
 }