Skip to content

Commit cd52925

Browse files
author
dimaspirit
committed
fixed one more time
1 parent 2070370 commit cd52925

File tree

4 files changed

+32
-12
lines changed

4 files changed

+32
-12
lines changed

samples/webrtc/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,8 @@ <h4>Call from <strong class="j-ic_initiator"></strong></h4>
220220
</script>
221221

222222
<script type="text/template" id="device_not_found">
223-
<span>Error: devices (camera or microphone) are not found.</span>
224-
&emsp;Login&nbsp;in&nbsp;as&nbsp;<%=name%>
223+
Error: devices (camera or microphone) are not found.
224+
<span class="text">&emsp;Login&nbsp;in&nbsp;as&nbsp;<%=name%></span>
225225
<button class='fw-link j-logout'>Logout</button>
226226
</script>
227227

samples/webrtc/js/app.js

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -249,10 +249,17 @@
249249

250250
app.currentSession.getUserMedia(mediaParams, function(err, stream) {
251251
if (err || !stream.getAudioTracks().length || !stream.getVideoTracks().length) {
252-
showErrorAccessPermission(err);
252+
var errorMsg = '';
253253

254-
qbApp.MsgBoard.update('device_not_found', {name: app.caller.full_name}, true);
254+
if(err && err.message) {
255+
errorMsg += 'Error: ' + err.message;
256+
} else {
257+
errorMsg += 'device_not_found';
258+
}
255259
app.currentSession.stop({});
260+
261+
showErrorAccessPermission(err);
262+
qbApp.MsgBoard.update(errorMsg, {name: app.caller.full_name}, true);
256263
} else {
257264
app.currentSession.call({}, function(error) {
258265
if(error) {
@@ -309,9 +316,17 @@
309316

310317
app.currentSession.getUserMedia(mediaParams, function(err, stream) {
311318
if (err || !stream.getAudioTracks().length || !stream.getVideoTracks().length) {
319+
var errorMsg = '';
320+
321+
if(err && err.message) {
322+
errorMsg += 'Error: ' + err.message;
323+
} else {
324+
errorMsg += 'device_not_found';
325+
}
326+
312327
showErrorAccessPermission(err);
313328

314-
qbApp.MsgBoard.update('device_not_found', {name: app.caller.full_name}, true);
329+
qbApp.MsgBoard.update(errorMsg, {name: app.caller.full_name}, true);
315330
isDeviceAccess = false;
316331
app.currentSession.stop({});
317332
} else {

samples/webrtc/js/msgBoard.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,14 @@
3131
* In first we trying found msg in MESSAGES object
3232
* then tpl with id like msg_title
3333
*/
34-
if(MESSAGES[msg_title]) {
35-
msg = MESSAGES[msg_title];
36-
} else if(!!document.querySelector('#' + msg_title)) {
37-
msg = _.template( document.querySelector('#' + msg_title).innerHTML )(params);
38-
} else {
39-
throw new Error('[msgBoard] Not found msg with name '+ msg_title);
34+
try {
35+
msg = _.template( document.querySelector('#' + msg_title).innerHTML )(params);
36+
} catch(e) {
37+
if(MESSAGES[msg_title]) {
38+
msg = MESSAGES[msg_title];
39+
} else {
40+
msg = msg_title;
41+
}
4042
}
4143

4244
msgBoardEl.innerHTML = '';

samples/webrtc/styles.css

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,9 +172,12 @@ body {
172172
color: #808080;
173173
}
174174

175-
.msg_board .error span {
175+
.msg_board .error {
176176
color: #ff2d55;
177177
}
178+
.msg_board span.text {
179+
color: #808080;
180+
}
178181

179182
.msg_board .fw-link {
180183
padding: 0;

0 commit comments

Comments
 (0)