Merge pull request #51 from Quantco/subdir-action-update

Fix updating actions in subdirs

Author: xhochy

scripts/update_actions.py

@@ -16,10 +16,11 @@ def update_workflow_actions(file_path: Path):
         else:
             action_with_rest = line.split(":")[1].strip()
             action, current_sha_with_version = action_with_rest.split("@")
+            action_repo = "/".join(action.split("/")[:2])
             current_sha, current_version = current_sha_with_version.split("#")
             current_sha = current_sha.strip()
             current_version = current_version.strip()
-            new_version, new_sha = get_latest_github_tag(action)
+            new_version, new_sha = get_latest_github_tag(action_repo)
             print(
                 f"{action}:"
                 f" current version: {current_version},"

tests/conftest.py

@@ -69,7 +69,8 @@ def generated_project(project_slug, project_description, generate_project):
 
 @pytest.fixture(autouse=True)
 def mock_get_latest_github_tag(monkeypatch):
-    def custom_get_latest_github_tag(_action: str) -> tuple[str, str]:
+    def custom_get_latest_github_tag(repo_name: str) -> tuple[str, str]:
+        assert repo_name.count("/") == 1
         return "v9.9.9", "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
 
     monkeypatch.setattr(

tests/test_template_update.py

@@ -8,10 +8,6 @@
 REPO_ROOT = Path(__file__).parent.parent
 
 
-def custom_get_latest_github_tag(_action: str) -> tuple[str, str]:
-    return "v9.9.9", "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
-
-
 def test_template_actions_update(tmp_path: Path):
     # Arrange
     src = REPO_ROOT / "template" / ".github" / "workflows"
@@ -44,6 +40,7 @@ def test_actions_update(tmp_path):
                 test:
                     steps:
                     - uses: actions/upload-release-asset@64e5e85fc528f162d7ba7ce2d15a3bb67efb3d80 # v0.0.0
+                    - uses: actions/upload-release-asset/subdir-action@64e5e85fc528f162d7ba7ce2d15a3bb67efb3d80 # v0.0.0
                 """
             ).lstrip()
         )
@@ -62,6 +59,7 @@ def test_actions_update(tmp_path):
                 test:
                     steps:
                     - uses: actions/upload-release-asset@aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa # v9.9.9
+                    - uses: actions/upload-release-asset/subdir-action@aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa # v9.9.9
                 """
             ).lstrip()
         )