Skip to content

Commit c20b7b2

Browse files
committed
Remove all backward compatibility requirements from refactoring plan
- Remove backward compatibility mentions from migration steps - Remove backward compatibility from success criteria - Remove feature flags for backward compatibility from mitigation strategies - Remove deprecation warnings from mitigation strategies - Focus on clean, modern codebase without legacy concerns
1 parent 1c63827 commit c20b7b2

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

REFACTORING_PLAN.md

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -263,15 +263,13 @@ connectomics/lightning/
263263
1. Create new module files
264264
2. Move functionality in logical chunks
265265
3. Update imports in `lit_model.py`
266-
4. Maintain backward compatibility (public API unchanged)
267-
5. Add integration tests for each module
268-
6. Update documentation
266+
4. Add integration tests for each module
267+
5. Update documentation
269268

270269
**Success Criteria:**
271270
- [ ] Each file < 500 lines
272271
- [ ] Clear separation of concerns
273272
- [ ] All existing tests pass
274-
- [ ] Public API unchanged (backward compatible)
275273
- [ ] Documentation updated
276274

277275
---
@@ -398,7 +396,6 @@ class DataConfig:
398396
- [x] `deep_supervision_clamp_min: float` (default: -20.0)
399397
- [x] `deep_supervision_clamp_max: float` (default: 20.0)
400398
- [x] Validation logic with warning for insufficient weights
401-
- [x] Backward compatible (defaults match old behavior)
402399
- [ ] Other hardcoded values (target interpolation, rejection sampling) - Future work
403400

404401
**Status:** ✅ Phase 2.3 (Deep Supervision) completed. Users can now customize deep supervision weights and clamping ranges via config.
@@ -490,14 +487,12 @@ def build_test_transforms(cfg: Config, keys: list[str] = None) -> Compose:
490487
- File size reduced from 791 to 727 lines (-64 lines, ~8% reduction)
491488
- Eliminated ~80% code duplication
492489
- Single source of truth for shared transform logic
493-
- Backward compatible (same public API)
494490

495491
**Action Items:**
496492
- [x] Extract shared logic into `_build_eval_transforms_impl()`
497493
- [x] Identify val/test-specific differences (4 key differences)
498494
- [x] Create mode-specific branching with clear comments
499495
- [x] Keep wrapper functions for API compatibility
500-
- [x] Backward compatible (public API unchanged)
501496

502497
**Status:** ✅ Phase 2.5 complete. Code duplication eliminated while preserving all functionality.
503498

@@ -986,10 +981,8 @@ See Priority 1.3 above for full details.
986981

987982
### Mitigation Strategies
988983
1. **Comprehensive testing** before and after each change
989-
2. **Feature flags** for backward compatibility
990-
3. **Deprecation warnings** before removal
991-
4. **Rollback plan** for each phase
992-
5. **User communication** via release notes
984+
2. **Rollback plan** for each phase
985+
3. **User communication** via release notes
993986

994987
---
995988

0 commit comments

Comments
 (0)