test: added more unittests for method handlers

Author: Pythonian

.env.example

@@ -11,4 +11,3 @@ DB_URL=postgresql://fastapiusr:fastapipwd@localhost:5432/fastapidb
 # DB_URL=sqlite:///./db.sqlite3
 # Uncomment the line below if DB_TYPE=mysql
 # DB_URL=mysql+pymysql://fastapiusr:fastapipwd@localhost:3306/fastapidb
-MYSQL_DRIVER=

api/v1/routes/blog.py

@@ -60,7 +60,6 @@ async def create_blog(
         )
 
     except HTTPException as http_err:
-        logger.warning(f"HTTP error occurred: {http_err.detail}")
         raise http_err
 
     except SQLAlchemyError as sql_err:
@@ -71,7 +70,7 @@ async def create_blog(
         )
 
     except Exception as e:
-        logger.error(f"Unexpected error occurred: {e}")
+        logger.error(f"Internal server error: {e}")
         raise HTTPException(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
             detail="Internal server error.",
@@ -131,7 +130,7 @@ async def list_blog(
             detail="Database error occurred.",
         )
     except Exception as e:
-        logger.error(f"Unexpected error occurred: {e}")
+        logger.error(f"Internal server error: {e}")
         raise HTTPException(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
             detail="Internal server error.",
@@ -166,17 +165,20 @@ async def read_blog(
         logger.info(f"Blog post with ID '{id}' retrieved successfully.")
         return BlogResponseSchema.model_validate(blog.__dict__)
 
+    except HTTPException as http_err:
+        raise http_err
+
     except SQLAlchemyError as e:
         logger.error(f"Database error occurred: {e}")
         raise HTTPException(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
             detail="Database error occurred.",
         )
     except Exception as e:
-        logger.error(f"Unexpected error occurred: {e}")
+        logger.error(f"Internal server error: {e}")
         raise HTTPException(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            detail="Unexpected error occurred.",
+            detail="Internal server error.",
         )
 
 
@@ -247,12 +249,9 @@ def update_blog(
         )
 
     except HTTPException as http_err:
-        # Log the HTTP exception
-        logger.warning(f"HTTP error occurred: {http_err.detail}")
         raise http_err
 
     except SQLAlchemyError as sql_err:
-        # Log SQLAlchemy errors
         logger.error(f"Database error occurred: {sql_err}")
         db.rollback()
         raise HTTPException(
@@ -261,8 +260,7 @@ def update_blog(
         )
 
     except Exception as e:
-        # Log other unexpected errors
-        logger.error(f"Unexpected error occurred: {e}")
+        logger.error(f"Internal server error: {e}")
         db.rollback()
         raise HTTPException(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
@@ -298,6 +296,9 @@ async def delete_blog(
         db.commit()
         logger.info(f"Blog post '{blog_to_delete.title}' deleted successfully.")
 
+    except HTTPException as http_err:
+        raise http_err
+
     except SQLAlchemyError as e:
         logger.error(f"Database error occurred: {e}")
         db.rollback()
@@ -307,7 +308,7 @@ async def delete_blog(
         )
 
     except Exception as e:
-        logger.error(f"Unexpected error occurred: {e}")
+        logger.error(f"Internal server error: {e}")
         db.rollback()
         raise HTTPException(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,

tests/database.py

@@ -47,3 +47,14 @@ def test_delete_invalid_blog_id(db_session_mock):
     response = client.delete("/api/v1/blogs/abc")
 
     assert response.status_code == 422
+
+
+def test_blog_post_not_found(db_session_mock):
+    """Simulate a request to delete a blog post that does not exist."""
+    db_session_mock.query.return_value.filter.return_value.first.return_value = None
+
+    response = client.delete("/api/v1/blogs/1")
+
+    assert response.status_code == 404
+    data = response.json()
+    assert data["detail"] == "Blog post with given id not found."

tests/v1/blog/test_delete_blog.py

@@ -53,3 +53,32 @@ def test_invalid_blog_post_id():
     response = client.get("/api/v1/blogs/abc")
 
     assert response.status_code == 422
+
+
+def test_deleted_blog_post_not_found(db_session_mock):
+    """Simulate a request to retrieve a blog post that has been deleted."""
+    db_session_mock.query.return_value.filter.return_value.first.return_value = None
+
+    response = client.get("/api/v1/blogs/1")
+
+    assert response.status_code == 404
+    data = response.json()
+    assert data["detail"] == "Blog post not found."
+
+
+def test_invalid_method():
+    response = client.post("/api/v1/blogs/1")
+
+    assert response.status_code == 405
+    data = response.json()
+    assert data["detail"] == "Method Not Allowed"
+
+
+def test_internal_server_error(mocker):
+    mocker.patch("api.v1.routes.blog", side_effect=Exception("Test exception"))
+
+    response = client.get("/api/v1/blogs/1")
+
+    assert response.status_code == 500
+    data = response.json()
+    assert data["detail"] == "Internal server error."

tests/v1/blog/test_read_blog.py

@@ -14,7 +14,7 @@ basepython = python3.10
 deps =
     -r requirements.txt
 commands =
-    pytest --cov-config=.coveragerc --cov=api --cov-report=html:htmlcov --cov-report=term-missing tests/
+    pytest --cov-config=.coveragerc --cov=api/v1 --cov-report=html:htmlcov --cov-report=term-missing tests/
 
 [testenv:type]
 description = run type checks