forked from Pycord-Development/pycord
-
Notifications
You must be signed in to change notification settings - Fork 1
Remove InvalidArgument exception in favor of built-in TypeError and ValueError #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
4
commits into
master
Choose a base branch
from
copilot/remove-invalidargument-exception
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+178
−201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/187/head:pr-187
git checkout pr-187This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord-next@refs/pull/187/head |
|
Holy I didn't expect it to do this |
Member
|
Lok |
- Replaced all 107 raise InvalidArgument statements with appropriate built-in exceptions - Removed InvalidArgument class from errors.py - Removed InvalidArgument from __all__ export - Updated all imports to remove InvalidArgument - Updated all docstrings referencing InvalidArgument - Fixed except clause in http.py to catch ValueError instead Co-authored-by: Soheab <33902984+Soheab@users.noreply.github.com>
Co-authored-by: Soheab <33902984+Soheab@users.noreply.github.com>
- Make docstrings more precise about when TypeError vs ValueError is raised - Update stage_instance.py, template.py, shard.py, reaction.py, webhook/async_.py - Address code review feedback for better developer guidance Co-authored-by: Soheab <33902984+Soheab@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove InvalidArgument in favor of built-in TypeError and ValueError
Remove InvalidArgument exception in favor of built-in TypeError and ValueError
Nov 7, 2025
Copilot finished work on behalf of
Soheab
November 7, 2025 19:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvalidArgumentduplicated behavior already provided by Python'sTypeErrorandValueError, adding unnecessary API surface and diverging from Python conventions.Changes
InvalidArgumentclass fromerrors.pyand__all__exportsraise InvalidArgumentstatements with:TypeError(34 cases) - for type mismatches (e.g.,isinstancechecks)ValueError(73 cases) - for invalid values with correct types (e.g., range checks, conflicting parameters)InvalidArgumentreferencesTypeErrororValueErrorinstead of genericInvalidArgumentMigration
Before:
After:
Net reduction of 22 lines while improving semantic clarity and Python standards compliance.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.