-
Notifications
You must be signed in to change notification settings - Fork 4
fix: renaming of statistical procedures #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
v1n0zavr1k
wants to merge
27
commits into
main
Choose a base branch
from
api/renaming-of-statistical-procedures
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
87bd31a
feat(generator): unify mixture generators and support canonical forms
plidan123 08756db
refactor: Rename folder algorithms to procedures
1062e1c
refactor: Rename member functions algorithm to compute
bfdf571
refactor: Fix naming of estimators
76838d6
refactor: Update register names
7e47e63
refactor: Update register names
78a7b35
refactor: Update procedures class names
9fa4aad
refactor: update tests
3c5c1b2
feat: Add general interface StatisticalProcedure
1280bdf
feat: Implement dynamic integrator selection, enabling the use of cus…
Amellgo 51a7303
feat: integration parameters are now part of the constructor
Amellgo 947f956
refactor: Rename algorithm classes and folders
0d635b3
fix: Fixing errors from the previous commit
a2789f7
feat: add batch support and refactor mixture evaluation logic
plidan123 476758e
Merge pull request #40 from PySATL/api/abstract-integrator
plidan123 8ec30a0
Merge pull request #38 from PySATL/feat/unify-mixture-generators
plidan123 d29b60e
Merge branch 'update' into feat/unify-mixture
plidan123 4296e34
fixed
plidan123 12b3205
fixed
plidan123 1b5138d
fixed
plidan123 5f7295c
fixed
plidan123 1cebc58
Merge pull request #46 from PySATL/feat/unify-mixture
plidan123 2727050
fixed
plidan123 8d481af
fixed
plidan123 b1c944c
fixed
plidan123 d4e7c06
fixed
plidan123 cb90a63
fixed
plidan123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/estimators/semiparametric/nmv_semiparametric_estimator.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| from src.procedures.semiparametric.nm_semi_param_algorithms.g_estimation_convolution import ( | ||
| NMEstimationDensityInvMT, | ||
| ) | ||
| from src.procedures.semiparametric.nm_semi_param_algorithms.sigma_estimation_eigenvalue_based import ( | ||
| NMEstimationSigmaEigenvals, | ||
| ) | ||
| from src.procedures.semiparametric.nm_semi_param_algorithms.sigma_estimation_empirical import ( | ||
| NMEstimationSigmaLaplace, | ||
| ) | ||
| from src.procedures.semiparametric.nv_semi_param_algorithms.g_estimation_given_mu import ( | ||
| NVEstimationDensityInvMT, | ||
| ) | ||
| from src.procedures.semiparametric.nv_semi_param_algorithms.g_estimation_post_widder import ( | ||
| NMVEstimationDensityPW, | ||
| ) | ||
| from src.procedures.semiparametric.nvm_semi_param_algorithms.g_estimation_given_mu import ( | ||
| NMVEstimationDensityInvMTquad, | ||
| ) | ||
| from src.procedures.semiparametric.nvm_semi_param_algorithms.g_estimation_given_mu_rqmc_based import ( | ||
| NMVEstimationDensityInvMTquadRQMCBased, | ||
| ) | ||
| from src.procedures.semiparametric.nvm_semi_param_algorithms.g_estimation_post_widder import ( | ||
| SemiParametricGEstimationPostWidder, | ||
| ) | ||
| from src.procedures.semiparametric.nvm_semi_param_algorithms.mu_estimation import (NMVEstimationMu) | ||
| from src.register.algorithm_purpose import AlgorithmPurpose | ||
| from src.register.register import Registry | ||
|
|
||
| ALGORITHM_REGISTRY: Registry = Registry() | ||
| ALGORITHM_REGISTRY.register("mu_estimation", AlgorithmPurpose.NMV_SEMIPARAMETRIC)(NMVEstimationMu) | ||
| ALGORITHM_REGISTRY.register("density_estim_inv_mellin_quad_int", AlgorithmPurpose.NMV_SEMIPARAMETRIC)( | ||
| NMVEstimationDensityInvMTquad | ||
| ) | ||
| ALGORITHM_REGISTRY.register("density_estim_deconv", AlgorithmPurpose.NM_SEMIPARAMETRIC)(NMEstimationDensityInvMT) | ||
| ALGORITHM_REGISTRY.register("sigma_estimation_eigenvalue", AlgorithmPurpose.NM_SEMIPARAMETRIC)( | ||
| NMEstimationSigmaEigenvals | ||
| ) | ||
| ALGORITHM_REGISTRY.register("sigma_estimation_laplace", AlgorithmPurpose.NM_SEMIPARAMETRIC)( | ||
| NMEstimationSigmaLaplace | ||
| ) | ||
| ALGORITHM_REGISTRY.register("density_estim_inv_mellin_rqmc_int", AlgorithmPurpose.NMV_SEMIPARAMETRIC)( | ||
| NMVEstimationDensityInvMTquadRQMCBased | ||
| ) | ||
| ALGORITHM_REGISTRY.register("density_estim_post_widder", AlgorithmPurpose.NMV_SEMIPARAMETRIC)( | ||
| SemiParametricGEstimationPostWidder | ||
| ) |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NV stands for Normal Variance, NMV -- for Normal Mean-Variance. I suggest renaming
NVSemiParametricGEstimationPostWiddertoNVEstimationDensityPW. I suppose you missedSemiParametricGEstimationPostWidderit should be renamed toNMVEstimationDensityPW. I know its messy. Thats why we refactor it : )