Remove Element for PyObject

Author: kngwyu

CHANGELOG.md

@@ -4,7 +4,6 @@
   - `PyArray::as_slice`, `PyArray::as_slice_mut`, `PyArray::as_array`, and `PyArray::as_array_mut` is now unsafe.
   - Introduce `PyArray::as_cell_slice`, `PyArray::to_vec`, and `PyArray::to_owned_array`
   - Rename `TypeNum` trait `Element`, and `NpyDataType` `DataType`
-  - Enables `PyArray<PyObject>`
 
 - v0.9.0
   - Update PyO3 to 0.10.0

src/types.rs

@@ -67,6 +67,7 @@ impl DataType {
             None
         }
     }
+    #[inline]
     pub fn into_ffi_dtype(self) -> NPY_TYPES {
         match self {
             DataType::Bool => NPY_TYPES::NPY_BOOL,
@@ -91,6 +92,7 @@ impl DataType {
 pub trait Element: Clone {
     const DATA_TYPE: DataType;
     fn is_same_type(other: i32) -> bool;
+    #[inline]
     fn ffi_dtype() -> NPY_TYPES {
         Self::DATA_TYPE.into_ffi_dtype()
     }
@@ -141,10 +143,3 @@ cfg_if! {
         impl_num_element!(u64, Uint64, NPY_ULONG, NPY_ULONGLONG);
     }
 }
-
-impl Element for pyo3::PyObject {
-    const DATA_TYPE: DataType = DataType::Object;
-    fn is_same_type(other: i32) -> bool {
-        other == Self::DATA_TYPE as i32
-    }
-}

tests/to_py.rs

@@ -12,23 +12,6 @@ fn to_pyarray_vec() {
     assert_eq!(arr.as_slice().unwrap(), &[1, 2, 3])
 }
 
-#[test]
-fn to_pyarray_object_vec() {
-    use pyo3::{AsPyRef, ToPyObject};
-    let gil = pyo3::Python::acquire_gil();
-    let py = gil.python();
-    let dict = pyo3::types::PyDict::new(py);
-    let list = pyo3::types::PyString::new(py, "Hello:)");
-    let a = vec![dict.to_object(py), list.to_object(py)];
-    let arr = a.to_pyarray(gil.python()).readonly();
-    for (a, b) in a.iter().zip(arr.as_slice().unwrap().iter()) {
-        assert_eq!(
-            a.as_ref(py).compare(b).map_err(|e| e.print(py)).unwrap(),
-            std::cmp::Ordering::Equal
-        );
-    }
-}
-
 #[test]
 fn to_pyarray_array() {
     let gil = pyo3::Python::acquire_gil();