prevent logger from bubbling up in notebook

Author: rickwierenga

pylabrobot/__init__.py

@@ -55,6 +55,8 @@ def setup_logger(log_dir: Optional[Union[Path, str]], level: int):
     fh.setFormatter(logging.Formatter("%(asctime)s - %(name)s - %(levelname)s - %(message)s"))
     logger.addHandler(fh)
 
+  logger.propagate = False
+
 
 def configure(cfg: Config):
   """Configure pylabrobot."""

pylabrobot/io/usb.py

@@ -316,7 +316,7 @@ async def setup(self):
     if len(devices) == 0:
       raise RuntimeError("USB device not found.")
     if len(devices) > 1:
-      logging.warning("Multiple devices found. Using the first one.")
+      logger.warning("Multiple devices found. Using the first one.")
     self.dev = devices[0]
 
     logger.info("Found USB device.")
@@ -357,7 +357,7 @@ async def stop(self):
 
     if self.dev is None:
       raise ValueError("USB device was not connected.")
-    logging.warning("Closing connection to USB device.")
+    logger.warning("Closing connection to USB device.")
     usb.util.dispose_resources(self.dev)
     self.dev = None
 

pylabrobot/resources/hamilton/hamilton_deck_tests.py

@@ -73,7 +73,7 @@ def test_summary(self):
   def test_assign_gigantic_resource(self):
     stanley_cup = StanleyCup_QUENCHER_FLOWSTATE_TUMBLER(name="HUGE")
     deck = STARLetDeck()
-    with self.assertLogs() as log:
+    with self.assertLogs("pylabrobot") as log:
       deck.assign_child_resource(stanley_cup, rails=1)
     self.assertEqual(
       log.output,

pylabrobot/storage/cytomat/cytomat.py

@@ -99,7 +99,7 @@ def _assemble_command(self, command_type: str, command: str, params: str):
 
   async def send_command(self, command_type: str, command: str, params: str) -> str:
     async def _send_command(command_str) -> str:
-      logging.debug(command_str.encode(self.serial_message_encoding))
+      logger.debug(command_str.encode(self.serial_message_encoding))
       await self.io.write(command_str.encode(self.serial_message_encoding))
       resp = (await self.io.read(128)).decode(self.serial_message_encoding)
       if len(resp) == 0:
@@ -122,7 +122,7 @@ async def _send_command(command_str) -> str:
         await self.reset_error_register()
         raise Exception(f"Unknown cytomat error code in response: {resp}")
 
-      logging.error("Command %s received an unknown response: '%s'", command_str, resp)
+      logger.error("Command %s received an unknown response: '%s'", command_str, resp)
       await self.reset_error_register()
       raise Exception(f"Unknown response from cytomat: {resp}")