relax the checks

Author: rickwierenga

pylabrobot/liquid_handling/liquid_handler.py

@@ -2326,6 +2326,7 @@ async def move_resource(
     )
     drop_kwargs = {k: v for k, v in backend_kwargs.items() if k not in extra}
 
+    print("moving to", to)
     await self.drop_resource(
       destination=to,
       offset=destination_offset,

pylabrobot/plate_reading/byonoy/byonoy_tests.py

@@ -27,6 +27,7 @@ async def test_move_reader_to_base(self):
     await self.lh.move_resource(self.reader, to=Coordinate(x=400, y=209.995, z=100))
 
     # move reader to base
+    print("moving")
     await self.lh.move_resource(
       self.reader,
       self.base.reader_holder,

pylabrobot/resources/carrier.py

@@ -151,8 +151,6 @@ def __init__(
 class PlateHolder(ResourceHolder):
   """A single site within a plate carrier."""
 
-  _accepted_child_types = (Plate, PlateAdapter, Lid)
-
   def __init__(
     self,
     name: str,
@@ -192,11 +190,6 @@ def assign_child_resource(
           "If a ResourceStack is assigned to a PlateHolder, the items "
           + f"must be Plates, not {type(resource.children[-1])}"
         )
-    elif not isinstance(resource, self._accepted_child_types):
-      raise TypeError(
-        "PlateHolder can only store Plate, PlateAdapter or ResourceStack "
-        + f"resources, not {type(resource)}"
-      )
     if isinstance(resource, Plate) and resource.plate_type != "skirted":
       raise ValueError("PlateHolder can only store plates that are skirted")
     return super().assign_child_resource(resource, location, reassign)
@@ -256,15 +249,6 @@ def serialize(self) -> dict:
       "pedestal_size_z": self.pedestal_size_z,
     }
 
-  def check_can_drop_resource_here(self, resource: Resource) -> None:
-    if not isinstance(resource, PlateHolder._accepted_child_types):
-      raise TypeError(
-        f"Cannot drop resource {resource.name} onto plate holder {self.name}. "
-        f"Only {self._accepted_child_types} resources are allowed."
-      )
-
-    super().check_can_drop_resource_here(resource)
-
 
 class PlateCarrier(Carrier):
   r"""Base class for plate carriers.

pylabrobot/resources/plate.py

@@ -308,3 +308,7 @@ def get_quadrant(
       wells.sort(key=lambda well: (well.location.x, -well.location.y))  # type: ignore
 
     return wells
+
+  def check_can_drop_resource_here(self, resource: Resource) -> None:
+    if not isinstance(resource, Lid):
+      raise RuntimeError(f"Can only drop Lid resources onto Plate '{self.name}'.")

pylabrobot/resources/resource_holder.py

@@ -78,7 +78,7 @@ def serialize(self):
     return {**super().serialize(), "child_location": serialize(self.child_location)}
 
   def check_can_drop_resource_here(self, resource: Resource) -> None:
-    if self.resource is not None:
+    if self.resource is not None and resource is not self.resource:
       raise RuntimeError(
         f"Cannot drop resource {resource.name} onto resource holder {self.name} while it already has a resource. "
         "Please remove the resource before dropping a new one."

pylabrobot/resources/resource_stack.py

@@ -145,3 +145,7 @@ def get_top_item(self) -> Resource:
       raise ValueError("Stack is empty")
 
     return self.children[-1]
+
+  def check_can_drop_resource_here(self, resource: Resource) -> None:
+    # for now, any resource can be dropped onto a stack.
+    pass