Skip to content

Commit 88ac451

Browse files
authored
remove python 3.8 support (#399)
1 parent 4670b8d commit 88ac451

File tree

4 files changed

+7
-16
lines changed

4 files changed

+7
-16
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
fail-fast: false
1313
matrix:
1414
os: [ubuntu-latest]
15-
version: [3.8, 3.9, "3.10", 3.11, 3.12]
15+
version: [3.9, "3.10", 3.11, 3.12]
1616

1717
name: Tests
1818
runs-on: ${{ matrix.os }}

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
</div>
44

55
<div style="text-align: center" align="center">
6-
<a href="https://docs.pylabrobot.org"><strong>Docs</strong></a> |
7-
<a href="https://discuss.pylabrobot.org"><strong>Forum</strong></a> |
8-
<a href="https://docs.pylabrobot.org/installation.html"><strong>Installation</strong></a> |
6+
<a href="https://docs.pylabrobot.org"><strong>Docs</strong></a> |
7+
<a href="https://discuss.pylabrobot.org"><strong>Forum</strong></a> |
8+
<a href="https://docs.pylabrobot.org/installation.html"><strong>Installation</strong></a> |
99
<a href="https://docs.pylabrobot.org/basic.html"><strong>Getting started</strong></a>
1010
</div>
1111

@@ -20,7 +20,7 @@ Advantages over proprietary software:
2020
- **Fast iteration**: PyLabRobot enables rapid development of protocols using atomic commands run interactively in Jupyter notebooks or the Python REPL. This decreases iteration time from minutes to seconds.
2121
- **Open-source**: PyLabRobot is open-source and free to use.
2222
- **Control**: With Python, you have ultimate flexibility to control your lab automation equipment. You can write Turing-complete protocols that include feedback loops.
23-
- **Modern**: PyLabRobot is built on modern Python 3.8+ features and async/await syntax.
23+
- **Modern**: PyLabRobot is built on modern Python 3.9+ features and async/await syntax.
2424
- **Fast support**: PyLabRobot has [an active community forum](https://discuss.pylabrobot.org) for support and discussion, and most pull requests are merged within a day.
2525

2626
### Liquid handling robots ([docs](https://docs.pylabrobot.org/basic.html))

pylabrobot/__init__.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,3 @@ def configure(cfg: Config):
6363

6464

6565
configure(CONFIG)
66-
67-
68-
# deprecation warning for 3.8
69-
if sys.version_info < (3, 9):
70-
warnings.warn(
71-
"Support for Python 3.8 is deprecated and will be removed in Dec 2024. "
72-
"Please upgrade to Python 3.9 or later."
73-
)

pylabrobot/liquid_handling/backends/hamilton/base.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
Sequence,
1313
Tuple,
1414
TypeVar,
15-
cast,
1615
)
1716

1817
from pylabrobot.liquid_handling.backends.backend import (
@@ -276,10 +275,10 @@ async def _write_and_read_command(
276275
read_timeout = self.read_timeout
277276

278277
loop = asyncio.get_event_loop()
279-
fut = loop.create_future()
278+
fut: asyncio.Future[str] = loop.create_future()
280279
self._start_reading(id_, loop, fut, cmd, read_timeout)
281280
result = await fut
282-
return cast(str, result) # Futures are generic in Python 3.9, but not in 3.8, so we need cast.
281+
return result
283282

284283
def _start_reading(
285284
self,

0 commit comments

Comments
 (0)