Skip to content

Commit 02c40a5

Browse files
committed
A bug fix about Initvals in RAM
1 parent f0e263e commit 02c40a5

File tree

3 files changed

+103
-103
lines changed

3 files changed

+103
-103
lines changed

tests/extension/thread_/ram_initval/test_thread_ram_initval.py

Lines changed: 100 additions & 100 deletions
Original file line numberDiff line numberDiff line change
@@ -1204,106 +1204,106 @@
12041204
mem[921] = 32'h3a3;
12051205
mem[922] = 32'h3a4;
12061206
mem[923] = 32'h3a5;
1207-
mem[924] = 32'h3a6;
1208-
mem[925] = 32'h3a7;
1209-
mem[926] = 32'h3a8;
1210-
mem[927] = 32'h3a9;
1211-
mem[928] = 32'h3aa;
1212-
mem[929] = 32'h3ab;
1213-
mem[930] = 32'h3ac;
1214-
mem[931] = 32'h3ad;
1215-
mem[932] = 32'h3ae;
1216-
mem[933] = 32'h3af;
1217-
mem[934] = 32'h3b0;
1218-
mem[935] = 32'h3b1;
1219-
mem[936] = 32'h3b2;
1220-
mem[937] = 32'h3b3;
1221-
mem[938] = 32'h3b4;
1222-
mem[939] = 32'h3b5;
1223-
mem[940] = 32'h3b6;
1224-
mem[941] = 32'h3b7;
1225-
mem[942] = 32'h3b8;
1226-
mem[943] = 32'h3b9;
1227-
mem[944] = 32'h3ba;
1228-
mem[945] = 32'h3bb;
1229-
mem[946] = 32'h3bc;
1230-
mem[947] = 32'h3bd;
1231-
mem[948] = 32'h3be;
1232-
mem[949] = 32'h3bf;
1233-
mem[950] = 32'h3c0;
1234-
mem[951] = 32'h3c1;
1235-
mem[952] = 32'h3c2;
1236-
mem[953] = 32'h3c3;
1237-
mem[954] = 32'h3c4;
1238-
mem[955] = 32'h3c5;
1239-
mem[956] = 32'h3c6;
1240-
mem[957] = 32'h3c7;
1241-
mem[958] = 32'h3c8;
1242-
mem[959] = 32'h3c9;
1243-
mem[960] = 32'h3ca;
1244-
mem[961] = 32'h3cb;
1245-
mem[962] = 32'h3cc;
1246-
mem[963] = 32'h3cd;
1247-
mem[964] = 32'h3ce;
1248-
mem[965] = 32'h3cf;
1249-
mem[966] = 32'h3d0;
1250-
mem[967] = 32'h3d1;
1251-
mem[968] = 32'h3d2;
1252-
mem[969] = 32'h3d3;
1253-
mem[970] = 32'h3d4;
1254-
mem[971] = 32'h3d5;
1255-
mem[972] = 32'h3d6;
1256-
mem[973] = 32'h3d7;
1257-
mem[974] = 32'h3d8;
1258-
mem[975] = 32'h3d9;
1259-
mem[976] = 32'h3da;
1260-
mem[977] = 32'h3db;
1261-
mem[978] = 32'h3dc;
1262-
mem[979] = 32'h3dd;
1263-
mem[980] = 32'h3de;
1264-
mem[981] = 32'h3df;
1265-
mem[982] = 32'h3e0;
1266-
mem[983] = 32'h3e1;
1267-
mem[984] = 32'h3e2;
1268-
mem[985] = 32'h3e3;
1269-
mem[986] = 32'h3e4;
1270-
mem[987] = 32'h3e5;
1271-
mem[988] = 32'h3e6;
1272-
mem[989] = 32'h3e7;
1273-
mem[990] = 32'h3e8;
1274-
mem[991] = 32'h3e9;
1275-
mem[992] = 32'h3ea;
1276-
mem[993] = 32'h3eb;
1277-
mem[994] = 32'h3ec;
1278-
mem[995] = 32'h3ed;
1279-
mem[996] = 32'h3ee;
1280-
mem[997] = 32'h3ef;
1281-
mem[998] = 32'h3f0;
1282-
mem[999] = 32'h3f1;
1283-
mem[1000] = 32'h3f2;
1284-
mem[1001] = 32'h3f3;
1285-
mem[1002] = 32'h3f4;
1286-
mem[1003] = 32'h3f5;
1287-
mem[1004] = 32'h3f6;
1288-
mem[1005] = 32'h3f7;
1289-
mem[1006] = 32'h3f8;
1290-
mem[1007] = 32'h3f9;
1291-
mem[1008] = 32'h3fa;
1292-
mem[1009] = 32'h3fb;
1293-
mem[1010] = 32'h3fc;
1294-
mem[1011] = 32'h3fd;
1295-
mem[1012] = 32'h3fe;
1296-
mem[1013] = 32'h3ff;
1297-
mem[1014] = 32'h400;
1298-
mem[1015] = 32'h401;
1299-
mem[1016] = 32'h402;
1300-
mem[1017] = 32'h403;
1301-
mem[1018] = 32'h404;
1302-
mem[1019] = 32'h405;
1303-
mem[1020] = 32'h406;
1304-
mem[1021] = 32'h407;
1305-
mem[1022] = 32'h408;
1306-
mem[1023] = 32'h409;
1207+
mem[924] = 32'h0;
1208+
mem[925] = 32'h0;
1209+
mem[926] = 32'h0;
1210+
mem[927] = 32'h0;
1211+
mem[928] = 32'h0;
1212+
mem[929] = 32'h0;
1213+
mem[930] = 32'h0;
1214+
mem[931] = 32'h0;
1215+
mem[932] = 32'h0;
1216+
mem[933] = 32'h0;
1217+
mem[934] = 32'h0;
1218+
mem[935] = 32'h0;
1219+
mem[936] = 32'h0;
1220+
mem[937] = 32'h0;
1221+
mem[938] = 32'h0;
1222+
mem[939] = 32'h0;
1223+
mem[940] = 32'h0;
1224+
mem[941] = 32'h0;
1225+
mem[942] = 32'h0;
1226+
mem[943] = 32'h0;
1227+
mem[944] = 32'h0;
1228+
mem[945] = 32'h0;
1229+
mem[946] = 32'h0;
1230+
mem[947] = 32'h0;
1231+
mem[948] = 32'h0;
1232+
mem[949] = 32'h0;
1233+
mem[950] = 32'h0;
1234+
mem[951] = 32'h0;
1235+
mem[952] = 32'h0;
1236+
mem[953] = 32'h0;
1237+
mem[954] = 32'h0;
1238+
mem[955] = 32'h0;
1239+
mem[956] = 32'h0;
1240+
mem[957] = 32'h0;
1241+
mem[958] = 32'h0;
1242+
mem[959] = 32'h0;
1243+
mem[960] = 32'h0;
1244+
mem[961] = 32'h0;
1245+
mem[962] = 32'h0;
1246+
mem[963] = 32'h0;
1247+
mem[964] = 32'h0;
1248+
mem[965] = 32'h0;
1249+
mem[966] = 32'h0;
1250+
mem[967] = 32'h0;
1251+
mem[968] = 32'h0;
1252+
mem[969] = 32'h0;
1253+
mem[970] = 32'h0;
1254+
mem[971] = 32'h0;
1255+
mem[972] = 32'h0;
1256+
mem[973] = 32'h0;
1257+
mem[974] = 32'h0;
1258+
mem[975] = 32'h0;
1259+
mem[976] = 32'h0;
1260+
mem[977] = 32'h0;
1261+
mem[978] = 32'h0;
1262+
mem[979] = 32'h0;
1263+
mem[980] = 32'h0;
1264+
mem[981] = 32'h0;
1265+
mem[982] = 32'h0;
1266+
mem[983] = 32'h0;
1267+
mem[984] = 32'h0;
1268+
mem[985] = 32'h0;
1269+
mem[986] = 32'h0;
1270+
mem[987] = 32'h0;
1271+
mem[988] = 32'h0;
1272+
mem[989] = 32'h0;
1273+
mem[990] = 32'h0;
1274+
mem[991] = 32'h0;
1275+
mem[992] = 32'h0;
1276+
mem[993] = 32'h0;
1277+
mem[994] = 32'h0;
1278+
mem[995] = 32'h0;
1279+
mem[996] = 32'h0;
1280+
mem[997] = 32'h0;
1281+
mem[998] = 32'h0;
1282+
mem[999] = 32'h0;
1283+
mem[1000] = 32'h0;
1284+
mem[1001] = 32'h0;
1285+
mem[1002] = 32'h0;
1286+
mem[1003] = 32'h0;
1287+
mem[1004] = 32'h0;
1288+
mem[1005] = 32'h0;
1289+
mem[1006] = 32'h0;
1290+
mem[1007] = 32'h0;
1291+
mem[1008] = 32'h0;
1292+
mem[1009] = 32'h0;
1293+
mem[1010] = 32'h0;
1294+
mem[1011] = 32'h0;
1295+
mem[1012] = 32'h0;
1296+
mem[1013] = 32'h0;
1297+
mem[1014] = 32'h0;
1298+
mem[1015] = 32'h0;
1299+
mem[1016] = 32'h0;
1300+
mem[1017] = 32'h0;
1301+
mem[1018] = 32'h0;
1302+
mem[1019] = 32'h0;
1303+
mem[1020] = 32'h0;
1304+
mem[1021] = 32'h0;
1305+
mem[1022] = 32'h0;
1306+
mem[1023] = 32'h0;
13071307
end
13081308
13091309

tests/extension/thread_/ram_initval/thread_ram_initval.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def mkLed():
1919
datawidth = 32
2020
addrwidth = 10
2121
numports = 1
22-
initvals = [i + 10 for i in range(2 ** addrwidth)]
22+
initvals = [i + 10 for i in range(2 ** addrwidth - 100)]
2323
myram = vthread.RAM(m, 'myram', clk, rst, datawidth, addrwidth,
2424
numports, initvals)
2525

veriloggen/types/ram.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ def mkRAMDefinition(name, datawidth=32, addrwidth=10, numports=2,
4545
initvals = new_initvals
4646

4747
if 2 ** addrwidth > len(initvals):
48-
initvals = list(initvals).extend(
48+
initvals.extend(
4949
[vtypes.Int(0, datawidth, base=16)
50-
for _ in 2 ** addrwidth - len(initvals)])
50+
for _ in range(2 ** addrwidth - len(initvals))])
5151

5252
m.Initial(
5353
*[mem[i](initval) for i, initval in enumerate(initvals)]

0 commit comments

Comments
 (0)