Skip to content

Commit fee7ee6

Browse files
committed
Update fs.test to make sure that files moved in the same FS get renamed
1 parent 47f9cfd commit fee7ee6

File tree

1 file changed

+19
-13
lines changed

1 file changed

+19
-13
lines changed

fs/test.py

Lines changed: 19 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1738,6 +1738,22 @@ def test_copy_dir_temp(self):
17381738
self._test_copy_dir("temp://")
17391739
self._test_copy_dir_write("temp://")
17401740

1741+
def test_move_dir_same_fs(self):
1742+
self.fs.makedirs("foo/bar/baz")
1743+
self.fs.makedir("egg")
1744+
self.fs.writetext("top.txt", "Hello, World")
1745+
self.fs.writetext("/foo/bar/baz/test.txt", "Goodbye, World")
1746+
1747+
fs.move.move_dir(self.fs, "foo", self.fs, "foo2")
1748+
1749+
expected = {"/egg", "/foo2", "/foo2/bar", "/foo2/bar/baz"}
1750+
self.assertEqual(set(walk.walk_dirs(self.fs)), expected)
1751+
self.assert_text("top.txt", "Hello, World")
1752+
self.assert_text("/foo2/bar/baz/test.txt", "Goodbye, World")
1753+
1754+
self.assertEqual(sorted(self.fs.listdir("/")), ["egg", "foo2", "top.txt"])
1755+
self.assertEqual(sorted(x.name for x in self.fs.scandir("/")), ["egg", "foo2", "top.txt"])
1756+
17411757
def _test_move_dir_write(self, protocol):
17421758
# Test moving to this filesystem from another.
17431759
other_fs = open_fs(protocol)
@@ -1760,19 +1776,6 @@ def test_move_dir_mem(self):
17601776
def test_move_dir_temp(self):
17611777
self._test_move_dir_write("temp://")
17621778

1763-
def test_move_same_fs(self):
1764-
self.fs.makedirs("foo/bar/baz")
1765-
self.fs.makedir("egg")
1766-
self.fs.writetext("top.txt", "Hello, World")
1767-
self.fs.writetext("/foo/bar/baz/test.txt", "Goodbye, World")
1768-
1769-
fs.move.move_dir(self.fs, "foo", self.fs, "foo2")
1770-
1771-
expected = {"/egg", "/foo2", "/foo2/bar", "/foo2/bar/baz"}
1772-
self.assertEqual(set(walk.walk_dirs(self.fs)), expected)
1773-
self.assert_text("top.txt", "Hello, World")
1774-
self.assert_text("/foo2/bar/baz/test.txt", "Goodbye, World")
1775-
17761779
def test_move_file_same_fs(self):
17771780
text = "Hello, World"
17781781
self.fs.makedir("foo").writetext("test.txt", text)
@@ -1782,6 +1785,9 @@ def test_move_file_same_fs(self):
17821785
self.assert_not_exists("foo/test.txt")
17831786
self.assert_text("foo/test2.txt", text)
17841787

1788+
self.assertEqual(self.fs.listdir("foo"), ["test2.txt"])
1789+
self.assertEqual(next(self.fs.scandir("foo")).name, "test2.txt")
1790+
17851791
def _test_move_file(self, protocol):
17861792
other_fs = open_fs(protocol)
17871793

0 commit comments

Comments
 (0)