Fixes from code review.

Author: atollk

CHANGELOG.md

@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 - Added `fs.copy.copy_file_if`, `fs.copy.copy_dir_if`, and `fs.copy.copy_fs_if`. 
   Closes [#458](https://github.com/PyFilesystem/pyfilesystem2/issues/458).
+- Added `fs.base.FS.getmodified`.
 
 ### Changed
 

docs/source/interface.rst

@@ -20,6 +20,7 @@ The following is a complete list of methods on PyFilesystem objects.
 * :meth:`~fs.base.FS.getdetails` Get details info namespace for a resource.
 * :meth:`~fs.base.FS.getinfo` Get info regarding a file or directory.
 * :meth:`~fs.base.FS.getmeta` Get meta information for a resource.
+* :meth:`~fs.base.FS.getmodified` Get info regarding the last modified time of a resource.
 * :meth:`~fs.base.FS.getospath` Get path with encoding expected by the OS.
 * :meth:`~fs.base.FS.getsize` Get the size of a file.
 * :meth:`~fs.base.FS.getsyspath` Get the system path of a resource, if one exists.

fs/base.py

@@ -754,7 +754,7 @@ def getmeta(self, namespace="standard"):
         supports_rename     `True` if this filesystem supports an
                             `os.rename` operation.
         supports_mtime      `True` if this filesystem supports a native
-                            operation to retreive the "last modified" time.
+                            operation to retrieve the "last modified" time.
         =================== ============================================
 
         Most builtin filesystems will provide all these keys, and third-

fs/ftpfs.py

@@ -12,6 +12,7 @@
 import socket
 import threading
 import typing
+import warnings
 from collections import OrderedDict
 from contextlib import contextmanager
 from ftplib import FTP
@@ -669,16 +670,23 @@ def getinfo(self, path, namespaces=None):
             )
 
         if "modified" in namespaces:
-            if "basic" in namespaces or "details" in namespaces:
-                raise ValueError(
-                    'Cannot use the "modified" namespace in combination with others.'
+            if "details" in namespaces:
+                warnings.warn(
+                    "FTPFS.getinfo called with both 'modified' and 'details'"
+                    " namespace. The former will be ignored.",
+                    UserWarning,
                 )
-            with self._lock:
-                with ftp_errors(self, path=path):
-                    cmd = "MDTM " + _encode(self.validatepath(path), self.ftp.encoding)
-                    response = self.ftp.sendcmd(cmd)
-                modified_info = {"modified": self._parse_ftp_time(response.split()[1])}
-                return Info({"modified": modified_info})
+            else:
+                with self._lock:
+                    with ftp_errors(self, path=path):
+                        cmd = "MDTM " + _encode(
+                            self.validatepath(path), self.ftp.encoding
+                        )
+                        response = self.ftp.sendcmd(cmd)
+                    modified_info = {
+                        "modified": self._parse_ftp_time(response.split()[1])
+                    }
+                    return Info({"modified": modified_info})
 
         if self.supports_mlst:
             with self._lock:

tests/test_memoryfs.py

@@ -72,13 +72,13 @@ def test_copy_preserve_time(self):
         self.fs.makedir("bar")
         self.fs.touch("foo/file.txt")
 
-        src_info = self.fs.getmodified("foo/file.txt")
+        src_datetime = self.fs.getmodified("foo/file.txt")
 
         self.fs.copy("foo/file.txt", "bar/file.txt", preserve_time=True)
         self.assertTrue(self.fs.exists("bar/file.txt"))
 
-        dst_info = self.fs.getmodified("bar/file.txt")
-        self.assertEqual(dst_info, src_info)
+        dst_datetime = self.fs.getmodified("bar/file.txt")
+        self.assertEqual(dst_datetime, src_datetime)
 
 
 class TestMemoryFile(unittest.TestCase):