Add flake8 linting (#351)

* Remove unused imports, fix line lengths

* Fix JSON exception catching

* Add linting tools

* More linting

* Fix broken/extra imports, long lines, unused variables

* Fix hasattr/getattr confusion

* Remove unused loop variables, fix comprehensions

* Update CHANGELOG

* Move tool configs to setup.cfg with the rest

Author: dargueta

.travis.yml

@@ -18,6 +18,9 @@ matrix:
     - name: "Type checking"
       python: "3.7"
       env: TOXENV=typecheck
+    - name: 'Lint'
+      python: '3.7'
+      env: TOXENV=lint
 
 before_install:
   - pip install -U tox tox-travis

CHANGELOG.md

@@ -23,12 +23,17 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Fixed abstract class import from `collections` which would break on Python 3.8
 - Fixed incorrect imports of `mock` on Python 3
 - Removed some unused imports and unused `requirements.txt` file
-- Added mypy checks to Travis
+- Added mypy checks to Travis. Closes [#332](https://github.com/PyFilesystem/pyfilesystem2/issues/332).
 - Fixed missing `errno.ENOTSUP` on PyPy. Closes [#338](https://github.com/PyFilesystem/pyfilesystem2/issues/338).
+- Fixed bug in a decorator that would trigger an `AttributeError` when a class
+  was created that implemented a deprecated method and had no docstring of its
+  own.
 
 ### Changed
 
 - Entire test suite has been migrated to [pytest](https://docs.pytest.org/en/latest/). Closes [#327](https://github.com/PyFilesystem/pyfilesystem2/issues/327).
+- Style checking is now enforced using `flake8`; this involved some code cleanup
+  such as removing unused imports.
 
 ## [2.4.10] - 2019-07-29
 

fs/_bulk.py

@@ -7,17 +7,18 @@
 from __future__ import unicode_literals
 
 import threading
+import typing
 
 from six.moves.queue import Queue
 
 from .copy import copy_file_internal
 from .errors import BulkCopyFailed
 from .tools import copy_file_data
 
-if False:  # typing.TYPE_CHECKING
+if typing.TYPE_CHECKING:
     from .base import FS
     from types import TracebackType
-    from typing import IO, Iterator, List, Optional, Mapping, Text, Type, Union
+    from typing import IO, List, Optional, Text, Type
 
 
 class _Worker(threading.Thread):
@@ -96,7 +97,7 @@ def start(self):
     def stop(self):
         """Stop the workers (will block until they are finished)."""
         if self.running and self.num_workers:
-            for worker in self.workers:
+            for _worker in self.workers:
                 self.queue.put(None)
             for worker in self.workers:
                 worker.join()

fs/_fscompat.py

@@ -1,5 +1,3 @@
-import sys
-
 import six
 
 try:

fs/_repr.py

@@ -5,7 +5,7 @@
 
 import typing
 
-if False:  # typing.TYPE_CHECKING
+if typing.TYPE_CHECKING:
     from typing import Text, Tuple
 
 

fs/_typing.py

@@ -12,7 +12,7 @@
 
 if _PY.major == 3 and _PY.minor == 5 and _PY.micro in (0, 1):
 
-    def overload(func):  # pragma: no cover
+    def overload(func):  # pragma: no cover  # noqa: F811
         return func
 
 

fs/_url_tools.py

@@ -1,9 +1,10 @@
 import re
 import six
 import platform
+import typing
 
-if False:  # typing.TYPE_CHECKING
-    from typing import Text, Union, BinaryIO
+if typing.TYPE_CHECKING:
+    from typing import Text
 
 _WINDOWS_PLATFORM = platform.system() == "Windows"
 

fs/appfs.py

@@ -15,7 +15,7 @@
 from ._repr import make_repr
 from appdirs import AppDirs
 
-if False:  # typing.TYPE_CHECKING
+if typing.TYPE_CHECKING:
     from typing import Optional, Text
 
 

fs/base.py

@@ -28,7 +28,7 @@
 from .time import datetime_to_epoch
 from .walk import Walker
 
-if False:  # typing.TYPE_CHECKING
+if typing.TYPE_CHECKING:
     from datetime import datetime
     from threading import RLock
     from typing import (
@@ -84,7 +84,7 @@ def _method(*args, **kwargs):
 """.format(
         method.__name__
     )
-    if getattr(_method, "__doc__"):
+    if hasattr(_method, "__doc__"):
         _method.__doc__ += deprecated_msg
 
     return _method
@@ -1624,7 +1624,8 @@ def hash(self, path, name):
 
         Arguments:
             path(str): A path on the filesystem.
-            name(str): One of the algorithms supported by the hashlib module, e.g. `"md5"`
+            name(str):
+                One of the algorithms supported by the hashlib module, e.g. `"md5"`
 
         Returns:
             str: The hex digest of the hash.

fs/compress.py

@@ -22,8 +22,8 @@
 from .errors import NoSysPath, MissingInfoNamespace
 from .walk import Walker
 
-if False:  # typing.TYPE_CHECKING
-    from typing import BinaryIO, Optional, Text, Tuple, Type, Union
+if typing.TYPE_CHECKING:
+    from typing import BinaryIO, Optional, Text, Tuple, Union
     from .base import FS
 
     ZipTime = Tuple[int, int, int, int, int, int]