Uploader #3
Uploader #3
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| message UploadAvatarReply { | ||
| string user_id = 1 [(graphql.field) = {name: "userId"}]; | ||
| uint64 size = 2; | ||
| } |
There was a problem hiding this comment.
The new upload mutations return uint64 sizes (UploadAvatarReply.size/UploadAvatarsReply.sizes), but the schema builder still exposes all 64‑bit integers as GraphQL String to avoid precision loss. At runtime prost_value_to_graphql converts Value::U64 to a numeric GqlValue, so calling uploadAvatar/uploadAvatars will advertise a String field in introspection yet emit JSON numbers, violating the declared type and risking client parsing errors. Please align the serialization with the declared string type before shipping the upload responses.
Useful? React with 👍 / 👎.
No description provided.