Prevent PHP Notice: Undefined index: sum (#104)

pluk77 · LKaemmerling · web-flow · commit 82e42b5a491e · 2023-04-24T20:11:52.000+02:00
* Prevent PHP notice fix #102 Signed-off-by: Marcel Berteler <pluk77@gmail.com> * Prevent PHP notice fix #102 Signed-off-by: Marcel Berteler <pluk77@gmail.com> --------- Signed-off-by: Marcel Berteler <pluk77@gmail.com> Co-authored-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
diff --git a/src/Prometheus/Storage/APC.php b/src/Prometheus/Storage/APC.php
@@ -383,7 +383,7 @@ private function collectHistograms(): array
                     'name' => $metaData['name'] . '_sum',
                     'labelNames' => [],
                     'labelValues' => $decodedLabelValues,
-                    'value' => $this->fromBinaryRepresentationAsInteger($histogramBuckets[$labelValues]['sum']),
+                    'value' => $this->fromBinaryRepresentationAsInteger($histogramBuckets[$labelValues]['sum'] ?? 0),
                 ];
             }
             $histograms[] = new MetricFamilySamples($data);
diff --git a/src/Prometheus/Storage/APCng.php b/src/Prometheus/Storage/APCng.php
@@ -661,7 +661,7 @@ private function collectHistograms(): array
                     'name' => $metaData['name'] . '_sum',
                     'labelNames' => [],
                     'labelValues' => $decodedLabelValues,
-                    'value' => $this->convertIncrementalIntegerToFloat($histogramBuckets[$labelValues]['sum']),
+                    'value' => $this->convertIncrementalIntegerToFloat($histogramBuckets[$labelValues]['sum'] ?? 0),
                 ];
             }
             $histograms[] = new MetricFamilySamples($data);

Original file line number	Diff line number	Diff line change
`@@ -383,7 +383,7 @@ private function collectHistograms(): array`
`383`	`383`	`'name' => $metaData['name'] . '_sum',`
`384`	`384`	`'labelNames' => [],`
`385`	`385`	`'labelValues' => $decodedLabelValues,`
`386`		`- 'value' => $this->fromBinaryRepresentationAsInteger($histogramBuckets[$labelValues]['sum']),`
	`386`	`+ 'value' => $this->fromBinaryRepresentationAsInteger($histogramBuckets[$labelValues]['sum'] ?? 0),`
`387`	`387`	`];`
`388`	`388`	`}`
`389`	`389`	`$histograms[] = new MetricFamilySamples($data);`
Original file line number	Diff line number	Diff line change
`@@ -661,7 +661,7 @@ private function collectHistograms(): array`
`661`	`661`	`'name' => $metaData['name'] . '_sum',`
`662`	`662`	`'labelNames' => [],`
`663`	`663`	`'labelValues' => $decodedLabelValues,`
`664`		`- 'value' => $this->convertIncrementalIntegerToFloat($histogramBuckets[$labelValues]['sum']),`
	`664`	`+ 'value' => $this->convertIncrementalIntegerToFloat($histogramBuckets[$labelValues]['sum'] ?? 0),`
`665`	`665`	`];`
`666`	`666`	`}`
`667`	`667`	`$histograms[] = new MetricFamilySamples($data);`