Skip to content

Commit 35af527

Browse files
committed
docker-compose -> docker compose
1 parent 08fca18 commit 35af527

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

README.APCng.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ The following table compares `APC` and `APCng` processing time for a series of o
4747
| APCng 100k keys / 2500 metrics | 274.7 | 84.0 | 34.6 | 4092.4 | 52.9x |
4848
| APCng 1M keys / 2500 metrics | 187.8 | 87.7 | 40.7 | 5396.4 | 50.1x |
4949

50-
The suite of engine-performance tests can be automatically executed by running `docker-compose run phpunit vendor/bin/phpunit tests/Test --group Performance`. This set of tests in not part of the default unit tests which get run, since they take quite a while to complete. Any significant change to the APC or APCng code should be followed by a performance-test run to quantify the before/after impact of the change. Currently this is triggered manually, but it could be automated as part of a Github workflow.
50+
The suite of engine-performance tests can be automatically executed by running `docker compose run phpunit vendor/bin/phpunit tests/Test --group Performance`. This set of tests in not part of the default unit tests which get run, since they take quite a while to complete. Any significant change to the APC or APCng code should be followed by a performance-test run to quantify the before/after impact of the change. Currently this is triggered manually, but it could be automated as part of a Github workflow.
5151

5252
## Known limitations
5353
One thing to note, the current implementation of the `Summary` observer should be avoided on busy servers. This is true for both the `APC` and `APCng` storage engines. The reason is simple: each observation (call to increment, set, etc) results in a new item being written to APCu. The default TTL for these items is 600 seconds. On a busy server that might be getting 1000 requests/second, that results in 600,000 APC cache items continually churning in and out of existence. This can put some interesting pressure on APCu, which could lead to rapid fragmentation of APCu memory. Definitely test before deploying in production.

README.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ composer require promphp/prometheus_push_gateway_php
143143

144144
Start a Redis instance:
145145
```
146-
docker-compose up redis
146+
docker compose up redis
147147
```
148148

149149
Run the tests:
@@ -157,16 +157,16 @@ composer install
157157

158158
## Black box testing
159159

160-
Just start the nginx, fpm & Redis setup with docker-compose:
160+
Just start the nginx, fpm & Redis setup with Docker Compose:
161161
```
162-
docker-compose up
162+
docker compose up
163163
```
164164
Pick the adapter you want to test.
165165

166166
```
167-
docker-compose run phpunit env ADAPTER=apc vendor/bin/phpunit tests/Test/
168-
docker-compose run phpunit env ADAPTER=apcng vendor/bin/phpunit tests/Test/
169-
docker-compose run phpunit env ADAPTER=redis vendor/bin/phpunit tests/Test/
167+
docker compose run phpunit env ADAPTER=apc vendor/bin/phpunit tests/Test/
168+
docker compose run phpunit env ADAPTER=apcng vendor/bin/phpunit tests/Test/
169+
docker compose run phpunit env ADAPTER=redis vendor/bin/phpunit tests/Test/
170170
```
171171

172172
## Performance testing
@@ -178,6 +178,6 @@ phpunit vendor/bin/phpunit tests/Test/ --group Performance
178178

179179
The test can also be run inside a container.
180180
```
181-
docker-compose up
182-
docker-compose run phpunit vendor/bin/phpunit tests/Test/ --group Performance
181+
docker compose up
182+
docker compose run phpunit vendor/bin/phpunit tests/Test/ --group Performance
183183
```

0 commit comments

Comments
 (0)