Split build and test CI so PowerShell Core can be used for the former

Since it's required in order to use our version tools.

Author: andyleejordan

.vsts-ci/templates/ci-general.yml

@@ -7,13 +7,6 @@ parameters:
     default: false
 
 steps:
-- task: PowerShell@2
-  displayName: PowerShell version
-  inputs:
-    targetType: inline
-    script: $PSVersionTable
-    pwsh: ${{ parameters.pwsh }}
-
 - checkout: self
 
 # NOTE: We either checkout the Git repo for PowerShellEditorServices, or we
@@ -62,19 +55,32 @@ steps:
     version: 6.0.x
     performMultiLevelLookup: true
 
+# The build script is always run with PowerShell Core
 - task: PowerShell@2
-  displayName: Build and test
+  displayName: Build and package
   inputs:
     targetType: inline
     script: |
-      Get-ChildItem env:
-      Get-Module -ListAvailable Pester
       Install-Module InvokeBuild -Scope CurrentUser -Force
       Install-Module platyPS -Scope CurrentUser -Force
-      Invoke-Build -Configuration Release
+      Invoke-Build -Configuration Release Package
       $PackageJson = Get-Content -Raw package.json | ConvertFrom-Json
       Write-Host "##vso[task.setvariable variable=vsixPath]$(Resolve-Path powershell-$($PackageJson.version).vsix)"
     workingDirectory: $(Build.SourcesDirectory)/vscode-powershell
+    pwsh: true
+
+# Tests in particular are run with either PowerShell Core or Windows PowerShell
+- task: PowerShell@2
+  displayName: Run unit tests
+  inputs:
+    targetType: inline
+    script: |
+      $PSVersionTable
+      Get-ChildItem env:
+      Get-Module -ListAvailable Pester
+      Install-Module InvokeBuild -Scope CurrentUser -Force
+      Invoke-Build -Configuration Release Test
+    workingDirectory: $(Build.SourcesDirectory)/vscode-powershell
     pwsh: ${{ parameters.pwsh }}
 
 - task: PowerShell@2
@@ -87,7 +93,7 @@ steps:
         Write-Host '##vso[task.LogIssue type=error;]PowerShell Editor Services bits were not built in release configuration!'
         exit 1
       }
-    pwsh: ${{ parameters.pwsh }}
+    pwsh: true
 
 - publish: $(vsixPath)
   artifact: vscode-powershell-vsix-$(System.JobId)

vscode-powershell.build.ps1

@@ -9,14 +9,6 @@ param(
 
 #Requires -Modules @{ ModuleName = "InvokeBuild"; ModuleVersion = "3.0.0" }
 
-# Sanity check our changelog version versus package.json (which lacks pre-release label)
-Import-Module $PSScriptRoot/tools/VersionTools.psm1
-$script:Version = Get-Version -RepositoryName vscode-powershell
-$script:PackageVersion = Get-MajorMinorPatch -Version $Version
-$script:PackageJson = Get-Content -Raw $PSScriptRoot/package.json | ConvertFrom-Json
-Assert-Build ($script:PackageJson.version -eq $script:PackageVersion)
-Write-Host "`n### Building Extension Version: $script:Version`n" -ForegroundColor Green
-
 function Get-EditorServicesPath {
     $psesRepoPath = if ($EditorServicesRepoPath) {
         $EditorServicesRepoPath
@@ -133,7 +125,14 @@ task TestEditorServices -If (Get-EditorServicesPath) {
 #region Package tasks
 
 task Package Build, {
-    Write-Host "`n### Packaging powershell-$script:PackageVersion.vsix`n" -ForegroundColor Green
+    # Sanity check our changelog version versus package.json (which lacks pre-release label)
+    Import-Module $PSScriptRoot/tools/VersionTools.psm1
+    $version = Get-Version -RepositoryName vscode-powershell
+    $packageVersion = Get-MajorMinorPatch -Version $version
+    $packageJson = Get-Content -Raw $PSScriptRoot/package.json | ConvertFrom-Json
+    Assert-Build ($packageJson.version -eq $packageVersion)
+
+    Write-Host "`n### Packaging powershell-$packageVersion.vsix`n" -ForegroundColor Green
     Assert-Build ((Get-Item ./modules).LinkType -ne "SymbolicLink") "Packaging requires a copy of PSES, not a symlink!"
     if (Test-IsPreRelease) {
         Write-Host "`n### This is a pre-release!`n" -ForegroundColor Green