implemented renamesymbol as a feature and structured under languageClientConsumers

Author: Razmo99

src/extension.ts

@@ -36,7 +36,6 @@ const PackageJSON: any = require("../package.json");
 const TELEMETRY_KEY = "0c6ae279ed8443289764825290e4f9e2-1a736e7c-1324-4338-be46-fc2a58ae4d14-7255";
 
 let languageConfigurationDisposable: vscode.Disposable;
-let languageRenameProvider:vscode.Disposable;
 let logger: Logger;
 let sessionManager: SessionManager;
 let languageClientConsumers: LanguageClientConsumer[] = [];
@@ -58,9 +57,6 @@ export async function activate(context: vscode.ExtensionContext): Promise<IPower
     const settings = getSettings();
     logger.writeVerbose(`Loaded settings:\n${JSON.stringify(settings, undefined, 2)}`);
 
-    const RenameSymbol = new RenameSymbolFeature();
-    languageRenameProvider = vscode.languages.registerRenameProvider(documentSelector,RenameSymbol);
-
     languageConfigurationDisposable = vscode.languages.setLanguageConfiguration(
         PowerShellLanguageId,
         {
@@ -156,7 +152,7 @@ export async function activate(context: vscode.ExtensionContext): Promise<IPower
         new RemoteFilesFeature(),
         new DebugSessionFeature(context, sessionManager, logger),
         new HelpCompletionFeature(),
-        RenameSymbol
+        new RenameSymbolFeature(documentSelector)
     ];
 
     sessionManager.setLanguageClientConsumers(languageClientConsumers);
@@ -190,5 +186,4 @@ export async function deactivate(): Promise<void> {
     await telemetryReporter.dispose();
 
     languageConfigurationDisposable.dispose();
-    languageRenameProvider.dispose();
 }

src/features/RenameSymbol.ts

@@ -4,7 +4,8 @@
 import vscode = require("vscode");
 import { RequestType } from "vscode-languageclient";
 import { LanguageClientConsumer } from "../languageClientConsumer";
-import { RenameProvider, WorkspaceEdit, TextDocument, CancellationToken, Position,Uri,Range } from "vscode";
+import { RenameProvider, WorkspaceEdit, TextDocument, CancellationToken, Position,Uri,Range, DocumentSelector } from "vscode";
+import { LanguageClient } from "vscode-languageclient/node";
 // eslint-disable-next-line @typescript-eslint/no-empty-interface
 interface IRenameSymbolRequestArguments {
     FileName?:string
@@ -45,7 +46,14 @@ export const RenameSymbolRequestType = new RequestType<IRenameSymbolRequestArgum
 export const PrepareRenameSymbolRequestType = new RequestType<IPrepareRenameSymbolRequestArguments, IPrepareRenameSymbolRequestResponse, void>("powerShell/PrepareRenameSymbol");
 
 export class RenameSymbolFeature extends LanguageClientConsumer implements RenameProvider {
+    private languageRenameProvider:vscode.Disposable;
 
+    constructor(documentSelector:DocumentSelector){
+        super();
+        this.languageRenameProvider = vscode.languages.registerRenameProvider(documentSelector,this);
+    }
+    // eslint-disable-next-line @typescript-eslint/no-empty-function
+    public override onLanguageClientSet(_languageClient: LanguageClient): void {}
     public async provideRenameEdits(document: TextDocument, position: Position, newName: string, _token: CancellationToken): Promise<WorkspaceEdit | undefined> {
 
         const req:IRenameSymbolRequestArguments = {
@@ -113,5 +121,7 @@ export class RenameSymbolFeature extends LanguageClientConsumer implements Renam
             return null;
         }
     }
-
+    public dispose(): void {
+        this.languageRenameProvider.dispose();
+    }
 }