Address feedback

Author: andyleejordan

tools/ReleaseTools.psm1

@@ -145,10 +145,12 @@ function Update-Changelog {
         [string]$RepositoryName,
 
         [Parameter(Mandatory)]
-        [ValidateScript({ Test-VersionIsValid -RepositoryName $RepositoryName -Version $_ })]
         [string]$Version
     )
 
+    # Since we depend on both parameters, we can't do this with `ValidateScript`.
+    Test-VersionIsValid -RepositoryName $RepositoryName -Version $Version
+
     # Get the repo object, latest release, and commits since its tag.
     $Repo = Get-GitHubRepository -OwnerName PowerShell -RepositoryName $RepositoryName
     $Commits = Use-Repository -RepositoryName $RepositoryName -Script {

tools/VersionTools.psm1

@@ -5,7 +5,7 @@
 
 using namespace System.Management.Automation
 
-class RepoNames: IValidateSetValuesGenerator {
+class RepoNames : IValidateSetValuesGenerator {
     # NOTE: This is super over-engineered, but it was fun.
     static [string[]] $Values = "vscode-powershell", "PowerShellEditorServices"
     [String[]] GetValidValues() { return [RepoNames]::Values }
@@ -150,5 +150,4 @@ function Test-VersionIsValid {
             }
         }
     }
-    return $true
 }