Move RenameSymbolSettings to RenameSymbol.ts

I know this differs from the existing style of the codebase but it makes sense to keep the separation of concerns local. Ideally PartialSettings is also updated to a stricter type like Record<String, Object> or something.

Author: JustinGrote

src/features/RenameSymbol.ts

@@ -7,6 +7,7 @@ import { LanguageClientConsumer } from "../languageClientConsumer";
 import { RenameProvider, WorkspaceEdit, TextDocument, CancellationToken, Position,Uri,Range, DocumentSelector } from "vscode";
 import { LanguageClient } from "vscode-languageclient/node";
 import { ILogger } from "../logging";
+import { PartialSettings } from "../settings";
 // eslint-disable-next-line @typescript-eslint/no-empty-interface
 interface RenameSymbolOptions {
     CreateAlias?:boolean
@@ -47,6 +48,11 @@ interface IPrepareRenameSymbolRequestResponse {
     message : string
 }
 
+export class RenameSymbolSettings extends PartialSettings {
+    createAlias = true;
+    acceptRenameDisclaimer = false;
+}
+
 const RenameSymbolRequestType = new RequestType<IRenameSymbolRequestArguments, IRenameSymbolRequestResponse, void>("powerShell/renameSymbol");
 const PrepareRenameSymbolRequestType = new RequestType<IPrepareRenameSymbolRequestArguments, IPrepareRenameSymbolRequestResponse, void>("powerShell/PrepareRenameSymbol");
 

src/settings.ts

@@ -7,6 +7,7 @@ import os = require("os");
 import { ILogger } from "./logging";
 import untildify from "untildify";
 import path = require("path");
+import { RenameSymbolSettings } from "./features/RenameSymbol";
 
 // TODO: Quite a few of these settings are unused in the client and instead
 // exist just for the server. Those settings do not need to be represented in
@@ -17,7 +18,7 @@ import path = require("path");
 // Perhaps we just get rid of this entirely?
 
 // eslint-disable-next-line @typescript-eslint/no-extraneous-class
-class PartialSettings { }
+export class PartialSettings { }
 
 export class Settings extends PartialSettings {
     powerShellAdditionalExePaths: PowerShellAdditionalExePathSettings = {};
@@ -156,9 +157,7 @@ class ButtonSettings extends PartialSettings {
     showPanelMovementButtons = false;
 }
 
-class RenameSymbolSettings extends PartialSettings {
-    createAlias = true;
-}
+
 
 // This is a recursive function which unpacks a WorkspaceConfiguration into our settings.
 function getSetting<TSetting>(key: string | undefined, value: TSetting, configuration: vscode.WorkspaceConfiguration): TSetting {