Use Windows GetTempPath instead of /tmp

Author: bilby91

contrib/win32/win32compat/socketio.c

@@ -29,9 +29,6 @@
 */
 
 #include <winsock2.h>
-#ifdef HAVE_AFUNIX_H
-#include <afunix.h>
-#endif
 #include <ws2tcpip.h>
 #include <mswsock.h>
 #include <errno.h>
@@ -41,6 +38,10 @@
 #include "inc\utf.h"
 #include "misc_internal.h"
 #include "debug.h"
+#include "../../../config.h"
+#ifdef HAVE_AFUNIX_H
+#include <afunix.h>
+#endif
 
 #define INTERNAL_SEND_BUFFER_SIZE 70*1024 //70KB
 #define INTERNAL_RECV_BUFFER_SIZE 70*1024 //70KB

contrib/win32/win32compat/w32fd.c

@@ -52,6 +52,7 @@
 #include <sys\utime.h>
 #include "misc_internal.h"
 #include "debug.h"
+#include "../../../config.h"
 
 /* internal table that stores the fd to w32_io mapping*/
 struct w32fd_table {

session.c

@@ -199,15 +199,26 @@ auth_input_request_forwarding(struct ssh *ssh, struct passwd * pw)
 	temporarily_use_uid(pw);
 
 #ifdef WINDOWS
-	/* Allocate a buffer for the socket name, and format the name. */
-	auth_sock_dir = xstrdup("C:\\tmp\\ssh-XXXXXXXXXX");
+	/* Use Windows temporal directory instead of unix `/tmp` folder */
+	static char tmp_file_path[MAX_PATH];
+	DWORD tmp_path_len = GetTempPath(MAX_PATH, tmp_file_path);
+	if (tmp_path_len > MAX_PATH || tmp_file_path == 0) {
+		error("Agent forwarding disabled: GetTempPath() failed.");
+		return 0;
+	}
 
+	char* ssh_prefix = xstrdup("ssh-XXXXXXXXXX");
+	size_t sock_dir_len = tmp_path_len + strlen(ssh_prefix) + 1;
+
+	auth_sock_dir = xmalloc(sock_dir_len);
+	memset(auth_sock_dir, 0, sock_dir_len);
+	strcat(auth_sock_dir, tmp_file_path);
+	strcat(auth_sock_dir, ssh_prefix);
 #else
 	/* Allocate a buffer for the socket name, and format the name. */
 	auth_sock_dir = xstrdup("/tmp/ssh-XXXXXXXXXX");
 #endif
 
-
 	/* Create private directory for socket */
 	if (mkdtemp(auth_sock_dir) == NULL) {
 		ssh_packet_send_debug(ssh, "Agent forwarding disabled: "