Revert "Skip tests broken by OmniSharp update"

This reverts commit e1817de.

Author: andyleejordan

test/PowerShellEditorServices.Test/Language/CompletionHandlerTests.cs

@@ -53,19 +53,17 @@ private Task<CompletionResults> GetCompletionResultsAsync(ScriptRegion scriptReg
                 CancellationToken.None);
         }
 
-        [SkippableFact]
+        [Fact]
         public async Task CompletesCommandInFile()
         {
-            Skip.If(VersionUtils.PSEdition == "Core", "OmniSharp records are broken!");
             (_, IEnumerable<CompletionItem> results) = await GetCompletionResultsAsync(CompleteCommandInFile.SourceDetails).ConfigureAwait(true);
             CompletionItem actual = Assert.Single(results);
             Assert.Equal(CompleteCommandInFile.ExpectedCompletion, actual);
         }
 
-        [SkippableFact]
+        [Fact]
         public async Task CompletesCommandFromModule()
         {
-            Skip.If(VersionUtils.PSEdition == "Core", "OmniSharp records are broken!");
             (_, IEnumerable<CompletionItem> results) = await GetCompletionResultsAsync(CompleteCommandFromModule.SourceDetails).ConfigureAwait(true);
             CompletionItem actual = Assert.Single(results);
             // NOTE: The tooltip varies across PowerShell and OS versions, so we ignore it.
@@ -76,7 +74,6 @@ public async Task CompletesCommandFromModule()
         [SkippableFact]
         public async Task CompletesTypeName()
         {
-            Skip.If(VersionUtils.PSEdition == "Core", "OmniSharp records are broken!");
             Skip.If(VersionUtils.PSEdition == "Desktop", "Windows PowerShell has trouble with this test right now.");
             (_, IEnumerable<CompletionItem> results) = await GetCompletionResultsAsync(CompleteTypeName.SourceDetails).ConfigureAwait(true);
             CompletionItem actual = Assert.Single(results);
@@ -98,26 +95,23 @@ public async Task CompletesTypeName()
         [SkippableFact]
         public async Task CompletesNamespace()
         {
-            Skip.If(VersionUtils.PSEdition == "Core", "OmniSharp records are broken!");
             Skip.If(VersionUtils.PSEdition == "Desktop", "Windows PowerShell has trouble with this test right now.");
             (_, IEnumerable<CompletionItem> results) = await GetCompletionResultsAsync(CompleteNamespace.SourceDetails).ConfigureAwait(true);
             CompletionItem actual = Assert.Single(results);
             Assert.Equal(CompleteNamespace.ExpectedCompletion, actual);
         }
 
-        [SkippableFact]
+        [Fact]
         public async Task CompletesVariableInFile()
         {
-            Skip.If(VersionUtils.PSEdition == "Core", "OmniSharp records are broken!");
             (_, IEnumerable<CompletionItem> results) = await GetCompletionResultsAsync(CompleteVariableInFile.SourceDetails).ConfigureAwait(true);
             CompletionItem actual = Assert.Single(results);
             Assert.Equal(CompleteVariableInFile.ExpectedCompletion, actual);
         }
 
-        [SkippableFact]
+        [Fact]
         public async Task CompletesAttributeValue()
         {
-            Skip.If(VersionUtils.PSEdition == "Core", "OmniSharp records are broken!");
             (_, IEnumerable<CompletionItem> results) = await GetCompletionResultsAsync(CompleteAttributeValue.SourceDetails).ConfigureAwait(true);
             // NOTE: Since the completions come through un-ordered from PowerShell, their SortText
             // (which has an index prepended from the original order) will mis-match our assumed
@@ -128,10 +122,9 @@ public async Task CompletesAttributeValue()
                 actual => Assert.Equal(actual with { Data = null, SortText = null }, CompleteAttributeValue.ExpectedCompletion3));
         }
 
-        [SkippableFact]
+        [Fact]
         public async Task CompletesFilePath()
         {
-            Skip.If(VersionUtils.PSEdition == "Core", "OmniSharp records are broken!");
             (_, IEnumerable<CompletionItem> results) = await GetCompletionResultsAsync(CompleteFilePath.SourceDetails).ConfigureAwait(true);
             Assert.NotEmpty(results);
             CompletionItem actual = results.First();

test/PowerShellEditorServices.Test/Services/Symbols/PSScriptAnalyzerTests.cs

@@ -8,7 +8,6 @@
 using Microsoft.PowerShell.EditorServices.Services;
 using Microsoft.PowerShell.EditorServices.Services.TextDocument;
 using Microsoft.PowerShell.EditorServices.Test;
-using Microsoft.PowerShell.EditorServices.Utility;
 using Xunit;
 
 namespace PowerShellEditorServices.Test.Services.Symbols
@@ -66,10 +65,9 @@ public async Task CanLoadPSScriptAnalyzerAsync()
             });
         }
 
-        [SkippableFact]
+        [Fact]
         public async Task DoesNotDuplicateScriptMarkersAsync()
         {
-            Skip.If(VersionUtils.PSEdition == "Core", "OmniSharp records are broken!");
             ScriptFile scriptFile = workspaceService.GetFileBuffer("untitled:Untitled-1", script);
             ScriptFile[] scriptFiles = { scriptFile };
 
@@ -85,10 +83,9 @@ await analysisService
             Assert.Single(scriptFile.DiagnosticMarkers);
         }
 
-        [SkippableFact]
+        [Fact]
         public async Task DoesNotClearParseErrorsAsync()
         {
-            Skip.If(VersionUtils.PSEdition == "Core", "OmniSharp records are broken!");
             // Causing a missing closing } parser error
             ScriptFile scriptFile = workspaceService.GetFileBuffer("untitled:Untitled-2", script.TrimEnd('}'));
             ScriptFile[] scriptFiles = { scriptFile };