Merge pull request #316 from PowerShell/daviwil/fix-315

daviwil · web-flow · commit f04823d193bb · 2016-12-12T06:18:56.000-08:00
Fix #315: Log an error message for unhandled request and event types
diff --git a/src/PowerShellEditorServices.Protocol/MessageProtocol/MessageDispatcher.cs b/src/PowerShellEditorServices.Protocol/MessageProtocol/MessageDispatcher.cs
@@ -278,6 +278,7 @@ protected async Task DispatchMessage(
                 else
                 {
                     // TODO: Message not supported error
+                    Logger.Write(LogLevel.Error, $"MessageDispatcher: No handler registered for Request type '{messageToDispatch.Method}'");
                 }
             }
             else if (messageToDispatch.MessageType == MessageType.Response)
@@ -297,11 +298,13 @@ protected async Task DispatchMessage(
                 else
                 {
                     // TODO: Message not supported error
+                    Logger.Write(LogLevel.Error, $"MessageDispatcher: No handler registered for Event type '{messageToDispatch.Method}'");
                 }
             }
             else
             {
                 // TODO: Return message not supported
+                Logger.Write(LogLevel.Error, $"MessageDispatcher received unknown message type of method '{messageToDispatch.Method}'");
             }
 
             if (handlerToAwait != null)

Original file line number	Diff line number	Diff line change
`@@ -278,6 +278,7 @@ protected async Task DispatchMessage(`
`278`	`278`	`else`
`279`	`279`	`{`
`280`	`280`	`// TODO: Message not supported error`
	`281`	`+ Logger.Write(LogLevel.Error, $"MessageDispatcher: No handler registered for Request type '{messageToDispatch.Method}'");`
`281`	`282`	`}`
`282`	`283`	`}`
`283`	`284`	`else if (messageToDispatch.MessageType == MessageType.Response)`
`@@ -297,11 +298,13 @@ protected async Task DispatchMessage(`
`297`	`298`	`else`
`298`	`299`	`{`
`299`	`300`	`// TODO: Message not supported error`
	`301`	`+ Logger.Write(LogLevel.Error, $"MessageDispatcher: No handler registered for Event type '{messageToDispatch.Method}'");`
`300`	`302`	`}`
`301`	`303`	`}`
`302`	`304`	`else`
`303`	`305`	`{`
`304`	`306`	`// TODO: Return message not supported`
	`307`	`+ Logger.Write(LogLevel.Error, $"MessageDispatcher received unknown message type of method '{messageToDispatch.Method}'");`
`305`	`308`	`}`
`306`	`309`
`307`	`310`	`if (handlerToAwait != null)`