Use a property to check module info status

Author: Kapil Borle

src/PowerShellEditorServices/Analysis/AnalysisService.cs

@@ -27,6 +27,15 @@ public class AnalysisService : IDisposable
         private const int NumRunspaces = 2;
         private RunspacePool analysisRunspacePool;
         private PSModuleInfo scriptAnalyzerModuleInfo;
+
+        private bool hasScriptAnalyzerModule
+        {
+            get
+            {
+                return scriptAnalyzerModuleInfo != null;
+            }
+        }
+
         private string[] activeRules;
         private string settingsPath;
 
@@ -160,7 +169,7 @@ public async Task<ScriptFileMarker[]> GetSemanticMarkersAsync(ScriptFile file, H
         public IEnumerable<string> GetPSScriptAnalyzerRules()
         {
             List<string> ruleNames = new List<string>();
-            if (scriptAnalyzerModuleInfo != null)
+            if (hasScriptAnalyzerModule)
             {
                 var ruleObjects = InvokePowerShell("Get-ScriptAnalyzerRule", new Dictionary<string, object>());
                 foreach (var rule in ruleObjects)
@@ -215,7 +224,7 @@ private async Task<ScriptFileMarker[]> GetSemanticMarkersAsync<TSettings>(
             string[] rules,
             TSettings settings) where TSettings : class
         {
-            if (this.scriptAnalyzerModuleInfo != null
+            if (hasScriptAnalyzerModule
                 && file.IsAnalysisEnabled
                 && (typeof(TSettings) == typeof(string) || typeof(TSettings) == typeof(Hashtable))
                 && (rules != null || settings != null))
@@ -246,16 +255,16 @@ private static PSModuleInfo FindPSScriptAnalyzerModule()
                   .AddParameter("First", 1);
 
                 var modules = ps.Invoke<PSModuleInfo>();
-                var scriptAnalyzerModuleInfo = modules == null ? null : modules.FirstOrDefault();
-                if (scriptAnalyzerModuleInfo != null)
+                var psModuleInfo = modules == null ? null : modules.FirstOrDefault();
+                if (psModuleInfo != null)
                 {
                     Logger.Write(
                         LogLevel.Normal,
                             string.Format(
                                 "PSScriptAnalyzer found at {0}",
-                                scriptAnalyzerModuleInfo.Path));
+                                psModuleInfo.Path));
 
-                    return scriptAnalyzerModuleInfo;
+                    return psModuleInfo;
                 }
 
                 Logger.Write(
@@ -267,7 +276,7 @@ private static PSModuleInfo FindPSScriptAnalyzerModule()
 
         private void EnumeratePSScriptAnalyzerRules()
         {
-            if (scriptAnalyzerModuleInfo != null)
+            if (hasScriptAnalyzerModule)
             {
                 var rules = GetPSScriptAnalyzerRules();
                 var sb = new StringBuilder();
@@ -288,7 +297,7 @@ private async Task<PSObject[]> GetDiagnosticRecordsAsync<TSettings>(
         {
             var diagnosticRecords = new PSObject[0];
 
-            if (this.scriptAnalyzerModuleInfo != null
+            if (hasScriptAnalyzerModule
                 && (typeof(TSettings) == typeof(string)
                     || typeof(TSettings) == typeof(Hashtable)))
             {