Merge pull request #322 from PowerShell/kapilmb/clear-problems-window

Clear diagnostic markers after file is closed

Author: daviwil

src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs

@@ -413,7 +413,7 @@ protected Task HandleDidOpenTextDocumentNotification(
             return Task.FromResult(true);
         }
 
-        protected Task HandleDidCloseTextDocumentNotification(
+        protected async Task HandleDidCloseTextDocumentNotification(
             TextDocumentIdentifier closeParams,
             EventContext eventContext)
         {
@@ -423,11 +423,10 @@ protected Task HandleDidCloseTextDocumentNotification(
             if (fileToClose != null)
             {
                 editorSession.Workspace.CloseFile(fileToClose);
+                await ClearMarkers(fileToClose, eventContext);
             }
 
             Logger.Write(LogLevel.Verbose, "Finished closing document.");
-
-            return Task.FromResult(true);
         }
 
         protected Task HandleDidChangeTextDocumentNotification(
@@ -496,15 +495,9 @@ protected async Task HandleDidChangeConfigurationNotification(
                 // event to clear the analysis markers that they already have.
                 if (!this.currentSettings.ScriptAnalysis.Enable.Value || settingsPathChanged)
                 {
-                    ScriptFileMarker[] emptyAnalysisDiagnostics = new ScriptFileMarker[0];
-
                     foreach (var scriptFile in editorSession.Workspace.GetOpenedFiles())
                     {
-                        await PublishScriptDiagnostics(
-                            scriptFile,
-                            emptyAnalysisDiagnostics,
-                            this.codeActionsPerFile,
-                            eventContext);
+                        await ClearMarkers(scriptFile, eventContext);
                     }
                 }
 
@@ -1215,6 +1208,16 @@ await PublishScriptDiagnostics(
             }
         }
 
+        private async Task ClearMarkers(ScriptFile scriptFile, EventContext eventContext)
+        {
+            // send empty diagnostic markers to clear any markers associated with the given file
+            await PublishScriptDiagnostics(
+                    scriptFile,
+                    new ScriptFileMarker[0],
+                    this.codeActionsPerFile,
+                    eventContext);
+        }
+
         private static async Task PublishScriptDiagnostics(
             ScriptFile scriptFile,
             ScriptFileMarker[] semanticMarkers,