Fix FindsOccurrencesOnParameter test

Author: andyleejordan

src/PowerShellEditorServices/Services/Symbols/SymbolType.cs

@@ -100,14 +100,17 @@ internal static SymbolKind GetSymbolKind(SymbolType symbolType)
             };
         }
 
-        // Provides a partial equivalence between type constraints and custom types.
+        // Provides a partial equivalence between type constraints and custom types, and between
+        // variables and parameters.
         internal static bool SymbolTypeMatches(SymbolType left, SymbolType right)
         {
             return left == right
                 || (left is SymbolType.Class or SymbolType.Enum or SymbolType.Type
                 && right is SymbolType.Class or SymbolType.Enum or SymbolType.Type)
                 || (left is SymbolType.EnumMember or SymbolType.Property
-                && right is SymbolType.EnumMember or SymbolType.Property);
+                && right is SymbolType.EnumMember or SymbolType.Property)
+                || (left is SymbolType.Variable or SymbolType.Parameter
+                && right is SymbolType.Variable or SymbolType.Parameter);
         }
     }
 }

src/PowerShellEditorServices/Services/Symbols/Visitors/SymbolVisitor.cs

@@ -73,9 +73,11 @@ public override AstVisitAction VisitFunctionDefinition(FunctionDefinitionAst fun
 
     public override AstVisitAction VisitParameter(ParameterAst parameterAst)
     {
+        // TODO: Can we fix the display name's type by visiting this in VisitVariableExpression and
+        // getting the TypeConstraintAst somehow?
         return _action(new SymbolReference(
             SymbolType.Parameter,
-            $"${parameterAst.Name.VariablePath.UserPath}",
+            "$" + parameterAst.Name.VariablePath.UserPath,
             VisitorUtils.GetParamDisplayName(parameterAst),
             parameterAst.Name.Extent,
             parameterAst.Extent,

test/PowerShellEditorServices.Test.Shared/Occurrences/FindOccurrencesOnParameter.cs

@@ -11,7 +11,7 @@ public static class FindOccurrencesOnParameterData
             file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
             text: string.Empty,
             startLineNumber: 1,
-            startColumnNumber: 31,
+            startColumnNumber: 30,
             startOffset: 0,
             endLineNumber: 0,
             endColumnNumber: 0,

test/PowerShellEditorServices.Test/Language/SymbolsServiceTests.cs

@@ -335,10 +335,24 @@ public void FindsOccurrencesOnFunction()
         [Fact]
         public void FindsOccurrencesOnParameter()
         {
-            IReadOnlyList<SymbolReference> occurrencesResult = GetOccurrences(FindOccurrencesOnParameterData.SourceDetails);
-            Assert.Equal(2, occurrencesResult.Count);
-            Assert.Equal("$myInput", occurrencesResult[occurrencesResult.Count - 1].SymbolName);
-            Assert.Equal(3, occurrencesResult[occurrencesResult.Count - 1].ScriptRegion.StartLineNumber);
+            IEnumerable<SymbolReference> symbols = GetOccurrences(FindOccurrencesOnParameterData.SourceDetails);
+            Assert.Collection(symbols,
+                (i) =>
+                {
+                    Assert.Equal("$myInput", i.SymbolName);
+                    // TODO: Parameter display strings need work.
+                    Assert.Equal("(parameter) [System.Object]$myInput", i.DisplayString);
+                    Assert.Equal(SymbolType.Parameter, i.SymbolType);
+                    AssertIsRegion(i.NameRegion, 1, 23, 1, 31);
+                    Assert.True(i.IsDeclaration);
+                },
+                (i) =>
+                {
+                    Assert.Equal("$myInput", i.SymbolName);
+                    Assert.Equal(SymbolType.Variable, i.SymbolType);
+                    AssertIsRegion(i.NameRegion, 3, 17, 3, 25);
+                    Assert.False(i.IsDeclaration);
+                });
         }
 
         [Fact]