Improve ConsoleService input handling for prompts

This change adds a new ReceivePromptResponse method to the ConsoleService
class so that prompt input received after a prompt is cancelled isn't
mistakenly executed as a command.  This change improves the user
experience of prompt timeouts in VS Code.

Author: daviwil

src/PowerShellEditorServices.Protocol/Server/DebugAdapter.cs

@@ -324,7 +324,7 @@ protected async Task HandleEvaluateRequest(
             if (isFromRepl)
             {
                 // Send the input through the console service
-                editorSession.ConsoleService.ReceiveInputString(
+                editorSession.ConsoleService.ExecuteCommand(
                     evaluateParams.Expression,
                     false);
             }

src/PowerShellEditorServices/Console/ConsoleService.cs

@@ -75,14 +75,14 @@ public ConsoleService(
         #region Public Methods
 
         /// <summary>
-        /// Called when an input string is received from the user.
+        /// Called when a command string is received from the user.
         /// If a prompt is currently active, the prompt handler is
         /// asked to handle the string.  Otherwise the string is
         /// executed in the PowerShellContext.
         /// </summary>
         /// <param name="inputString">The input string to evaluate.</param>
         /// <param name="echoToConsole">If true, the input will be echoed to the console.</param>
-        public void ReceiveInputString(string inputString, bool echoToConsole)
+        public void ExecuteCommand(string inputString, bool echoToConsole)
         {
             if (this.activePromptHandler != null)
             {
@@ -111,6 +111,25 @@ public void ReceiveInputString(string inputString, bool echoToConsole)
             }
         }
 
+        /// <summary>
+        /// Provides a direct path for a caller that just wants to provide
+        /// user response to a prompt without executing a command if there
+        /// is no active prompt.
+        /// </summary>
+        /// <param name="promptResponse">The user's response to the active prompt.</param>
+        /// <param name="echoToConsole">If true, the input will be echoed to the console.</param>
+        /// <returns>True if there was a prompt, false otherwise.</returns>
+        public bool ReceivePromptResponse(string promptResponse, bool echoToConsole)
+        {
+            if (this.activePromptHandler != null)
+            {
+                this.ExecuteCommand(promptResponse, echoToConsole);
+                return true;
+            }
+
+            return false;
+        }
+
         /// <summary>
         /// Pushes a new IPromptHandlerContext onto the stack.  This
         /// is used when a prompt handler context is only needed for

test/PowerShellEditorServices.Test/Console/ConsoleServiceTests.cs

@@ -168,7 +168,7 @@ public async Task ReceivesChoicePrompt()
             await promptTask;
 
             // Respond to the prompt and wait for the prompt to complete
-            this.consoleService.ReceiveInputString("apple", false);
+            this.consoleService.ExecuteCommand("apple", false);
             await executeTask;
 
             string[] outputLines =
@@ -233,8 +233,8 @@ public async Task ReceivesChoicePromptHelp()
             await promptTask;
 
             // Respond to the prompt and wait for the help prompt to appear
-            this.consoleService.ReceiveInputString("?", false);
-            this.consoleService.ReceiveInputString("A", false);
+            this.consoleService.ExecuteCommand("?", false);
+            this.consoleService.ExecuteCommand("A", false);
             await executeTask;
 
             string[] outputLines =
@@ -265,10 +265,10 @@ public async Task ReceivesInputPrompt()
             await promptTask;
 
             // Respond to the prompt and wait for execution to complete
-            this.consoleService.ReceiveInputString("John", true);
-            this.consoleService.ReceiveInputString("40", true);
-            this.consoleService.ReceiveInputString("Windows PowerShell In Action", true);
-            this.consoleService.ReceiveInputString("", false);
+            this.consoleService.ExecuteCommand("John", true);
+            this.consoleService.ExecuteCommand("40", true);
+            this.consoleService.ExecuteCommand("Windows PowerShell In Action", true);
+            this.consoleService.ExecuteCommand("", false);
             await executeTask;
 
             string[] outputLines =
@@ -329,7 +329,7 @@ public async Task ReceivesReadHostPrompt()
             await promptTask;
 
             // Respond to the prompt and wait for execution to complete
-            this.consoleService.ReceiveInputString("John", true);
+            this.consoleService.ExecuteCommand("John", true);
             await executeTask;
 
             string[] outputLines =
@@ -375,7 +375,7 @@ public async Task ReceivesReadHostPromptWithFieldName()
             await promptTask;
 
             // Respond to the prompt and wait for execution to complete
-            this.consoleService.ReceiveInputString("John", true);
+            this.consoleService.ExecuteCommand("John", true);
             await executeTask;
 
             string[] outputLines =