Skip to content

Commit d758eda

Browse files
dfinkedfinke
committed
Fixed Expand Alias
1 parent e8750b9 commit d758eda

File tree

4 files changed

+83
-69
lines changed

4 files changed

+83
-69
lines changed

‎src/PowerShellEditorServices.Host/LanguageServer.cs‎

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -156,11 +156,10 @@ await editorSession.PowerShellContext.ExecuteCommand<object>(
156156
private async Task HandleExpandAliasRequest(
157157
string content,
158158
EditorSession editorSession,
159-
RequestContext<object, object> requestContext)
159+
RequestContext<string, object> requestContext)
160160
{
161-
var psCommand = new PSCommand();
162161
var script = @"
163-
function Expand-Alias {
162+
function __Expand-Alias {
164163
165164
param($targetScript)
166165
@@ -181,14 +180,14 @@ Sort Start -Descending
181180
}
182181
183182
$targetScript
184-
}
185-
M
186-
Expand-Alias @'" + "\r\n" + content + "\r\n'@";
187-
183+
}";
184+
var psCommand = new PSCommand();
188185
psCommand.AddScript(script);
186+
await editorSession.PowerShellContext.ExecuteCommand<PSObject>(psCommand);
189187

190-
var result = await editorSession.PowerShellContext.ExecuteCommand<PSObject>(
191-
psCommand);
188+
psCommand = new PSCommand();
189+
psCommand.AddCommand("__Expand-Alias").AddArgument(content);
190+
var result = await editorSession.PowerShellContext.ExecuteCommand<string>(psCommand);
192191

193192
await requestContext.SendResult(result.First().ToString());
194193
}

‎src/PowerShellEditorServices.Protocol/LanguageServer/ExpandAliasRequest.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ namespace Microsoft.PowerShell.EditorServices.Protocol.LanguageServer
1010
public class ExpandAliasRequest
1111
{
1212
public static readonly
13-
RequestType<string, object, object> Type =
14-
RequestType<string, object, object>.Create("powerShell/expandAlias");
13+
RequestType<string, string, object> Type =
14+
RequestType<string, string, object>.Create("powerShell/expandAlias");
1515
}
1616
}

‎src/PowerShellEditorServices/Session/PowerShellContext.cs‎

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ public Task<RunspaceHandle> GetRunspaceHandle()
166166
/// execution completes.
167167
/// </returns>
168168
public async Task<IEnumerable<TResult>> ExecuteCommand<TResult>(
169-
PSCommand psCommand,
169+
PSCommand psCommand,
170170
bool sendOutputToHost = false)
171171
{
172172
// If the debugger is active and the caller isn't on the pipeline
@@ -207,7 +207,7 @@ public async Task<IEnumerable<TResult>> ExecuteCommand<TResult>(
207207
this.debuggerStoppedTask != null)
208208
{
209209
Logger.Write(
210-
LogLevel.Verbose,
210+
LogLevel.Verbose,
211211
string.Format(
212212
"Attempting to execute nested pipeline command(s):\r\n\r\n{0}",
213213
GetStringForPSCommand(psCommand)));
@@ -231,7 +231,7 @@ public async Task<IEnumerable<TResult>> ExecuteCommand<TResult>(
231231
else
232232
{
233233
Logger.Write(
234-
LogLevel.Verbose,
234+
LogLevel.Verbose,
235235
string.Format(
236236
"Attempting to execute command(s):\r\n\r\n{0}",
237237
GetStringForPSCommand(psCommand)));
@@ -262,15 +262,19 @@ await Task.Factory.StartNew<IEnumerable<TResult>>(
262262

263263
if (this.powerShell.HadErrors)
264264
{
265-
// TODO: Find a good way to extract errors!
266-
Logger.Write(
267-
LogLevel.Error,
268-
"Execution completed with errors.");
265+
string errorMessage = "Execution completed with errors:\r\n\r\n";
266+
267+
foreach (var error in this.powerShell.Streams.Error)
268+
{
269+
errorMessage += error.ToString() + "\r\n";
270+
}
271+
272+
Logger.Write(LogLevel.Error, errorMessage);
269273
}
270274
else
271275
{
272276
Logger.Write(
273-
LogLevel.Verbose,
277+
LogLevel.Verbose,
274278
"Execution completed successfully.");
275279
}
276280

@@ -411,7 +415,7 @@ internal void ReleaseRunspaceHandle(RunspaceHandle runspaceHandle)
411415
if (!this.runspaceWaitQueue.IsEmpty)
412416
{
413417
this.currentRunspaceHandle = new RunspaceHandle(this.currentRunspace, this);
414-
dequeuedTask =
418+
dequeuedTask =
415419
this.runspaceWaitQueue.Dequeue(
416420
this.currentRunspaceHandle);
417421
}
@@ -442,7 +446,7 @@ private void OnSessionStateChanged(object sender, SessionStateChangedEventArgs e
442446
this.SessionState.ToString(),
443447
e.NewSessionState.ToString()));
444448

445-
this.SessionState = e.NewSessionState;
449+
this.SessionState = e.NewSessionState;
446450

447451
if (this.SessionStateChanged != null)
448452
{
@@ -557,7 +561,7 @@ private void SetExecutionPolicy(ExecutionPolicy desiredExecutionPolicy)
557561
currentPolicy = result.FirstOrDefault();
558562
}
559563

560-
if (desiredExecutionPolicy < currentPolicy ||
564+
if (desiredExecutionPolicy < currentPolicy ||
561565
desiredExecutionPolicy == ExecutionPolicy.Bypass ||
562566
currentPolicy == ExecutionPolicy.Undefined)
563567
{

‎test/PowerShellEditorServices.Test.Host/ScenarioTests.cs‎

Lines changed: 58 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ public class ScenarioTests : IDisposable
2020
{
2121
private int messageId = 0;
2222

23-
private LanguageServiceManager languageServiceManager =
23+
private LanguageServiceManager languageServiceManager =
2424
new LanguageServiceManager();
2525

26-
private MessageReader MessageReader
27-
{
28-
get { return this.languageServiceManager.MessageReader; }
26+
private MessageReader MessageReader
27+
{
28+
get { return this.languageServiceManager.MessageReader; }
2929
}
3030

3131
private MessageWriter MessageWriter
@@ -109,7 +109,7 @@ await this.SendRequest(
109109
Assert.Equal("string", consoleFileNameItem.Detail);
110110
}
111111

112-
[Fact(Skip="Skipped until variable documentation gathering is added back.")]
112+
[Fact(Skip = "Skipped until variable documentation gathering is added back.")]
113113
public async Task CompletesDetailOnVariableDocSuggestion()
114114
{
115115
//await this.SendOpenFileEvent("TestFiles\\CompleteFunctionName.ps1");
@@ -429,51 +429,62 @@ await this.SendRequestWithoutWait(
429429
Assert.Equal("stdout", outputEvent.Category);
430430
}
431431

432+
[Fact]
433+
public async Task ServiceExpandsAliases()
434+
{
435+
string expandedText =
436+
await this.SendRequest(
437+
ExpandAliasRequest.Type,
438+
"gci\r\npwd");
439+
440+
Assert.Equal("Get-ChildItem\r\nGet-Location", expandedText);
441+
}
442+
432443
[Fact]//(Skip = "Choice prompt functionality is currently in transition to a new model.")]
433444
public async Task ServiceExecutesReplCommandAndReceivesChoicePrompt()
434445
{
435446
// TODO: This test is removed until a new choice prompt strategy is determined.
436447

437-
// string choiceScript =
438-
// @"
439-
// $caption = ""Test Choice"";
440-
// $message = ""Make a selection"";
441-
// $choiceA = new-Object System.Management.Automation.Host.ChoiceDescription ""&A"",""A"";
442-
// $choiceB = new-Object System.Management.Automation.Host.ChoiceDescription ""&B"",""B"";
443-
// $choices = [System.Management.Automation.Host.ChoiceDescription[]]($choiceA,$choiceB);
444-
// $response = $host.ui.PromptForChoice($caption, $message, $choices, 1)
445-
// $response";
446-
447-
// await this.MessageWriter.WriteMessage(
448-
// new ReplExecuteRequest
449-
// {
450-
// Arguments = new ReplExecuteArgs
451-
// {
452-
// CommandString = choiceScript
453-
// }
454-
// });
455-
456-
// // Wait for the choice prompt event and check expected values
457-
// ReplPromptChoiceEvent replPromptChoiceEvent = this.WaitForMessage<ReplPromptChoiceEvent>();
458-
// Assert.Equal(1, replPromptChoiceEvent.Body.DefaultChoice);
459-
460-
// // Respond to the prompt event
461-
// await this.MessageWriter.WriteMessage(
462-
// new ReplPromptChoiceResponse
463-
// {
464-
// Body = new ReplPromptChoiceResponseBody
465-
// {
466-
// Choice = 0
467-
// }
468-
// });
469-
470-
// // Wait for the selection to appear as output
471-
// ReplWriteOutputEvent replWriteLineEvent = this.WaitForMessage<ReplWriteOutputEvent>();
472-
// Assert.Equal("0", replWriteLineEvent.Body.LineContents);
448+
// string choiceScript =
449+
// @"
450+
// $caption = ""Test Choice"";
451+
// $message = ""Make a selection"";
452+
// $choiceA = new-Object System.Management.Automation.Host.ChoiceDescription ""&A"",""A"";
453+
// $choiceB = new-Object System.Management.Automation.Host.ChoiceDescription ""&B"",""B"";
454+
// $choices = [System.Management.Automation.Host.ChoiceDescription[]]($choiceA,$choiceB);
455+
// $response = $host.ui.PromptForChoice($caption, $message, $choices, 1)
456+
// $response";
457+
458+
// await this.MessageWriter.WriteMessage(
459+
// new ReplExecuteRequest
460+
// {
461+
// Arguments = new ReplExecuteArgs
462+
// {
463+
// CommandString = choiceScript
464+
// }
465+
// });
466+
467+
// // Wait for the choice prompt event and check expected values
468+
// ReplPromptChoiceEvent replPromptChoiceEvent = this.WaitForMessage<ReplPromptChoiceEvent>();
469+
// Assert.Equal(1, replPromptChoiceEvent.Body.DefaultChoice);
470+
471+
// // Respond to the prompt event
472+
// await this.MessageWriter.WriteMessage(
473+
// new ReplPromptChoiceResponse
474+
// {
475+
// Body = new ReplPromptChoiceResponseBody
476+
// {
477+
// Choice = 0
478+
// }
479+
// });
480+
481+
// // Wait for the selection to appear as output
482+
// ReplWriteOutputEvent replWriteLineEvent = this.WaitForMessage<ReplWriteOutputEvent>();
483+
// Assert.Equal("0", replWriteLineEvent.Body.LineContents);
473484
}
474485

475486
private async Task<TResult> SendRequest<TParams, TResult, TError>(
476-
RequestType<TParams, TResult, TError> requestType,
487+
RequestType<TParams, TResult, TError> requestType,
477488
TParams requestParams)
478489
{
479490
await this.SendRequestWithoutWait(requestType, requestParams);
@@ -491,7 +502,7 @@ await this.MessageWriter.WriteMessage(
491502
this.messageId.ToString(),
492503
requestType.TypeName,
493504
JToken.FromObject(requestParams)));
494-
}
505+
}
495506

496507
private async Task SendEvent<TParams>(EventType<TParams> eventType, TParams eventParams)
497508
{
@@ -506,9 +517,9 @@ private async Task SendOpenFileEvent(string filePath, bool waitForDiagnostics =
506517
string fileContents = string.Join(Environment.NewLine, File.ReadAllLines(filePath));
507518

508519
await this.SendEvent(
509-
DidOpenTextDocumentNotification.Type,
510-
new DidOpenTextDocumentNotification()
511-
{
520+
DidOpenTextDocumentNotification.Type,
521+
new DidOpenTextDocumentNotification()
522+
{
512523
Uri = filePath,
513524
Text = fileContents
514525
});
@@ -535,7 +546,7 @@ private TParams WaitForEvent<TParams>(EventType<TParams> eventType)
535546
}
536547

537548
private TResult WaitForResponse<TParams, TResult, TError>(
538-
RequestType<TParams, TResult, TError> requestType,
549+
RequestType<TParams, TResult, TError> requestType,
539550
int expectedId)
540551
{
541552
// TODO: Integrate timeout!

0 commit comments

Comments
 (0)