Treat all relative paths for scriptAnalysisSettingsPath as workspace relative. You can also use an absolute path or string empty for the built-in defaults.

Author: rkeithhill

src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs

@@ -6,6 +6,7 @@
 using Microsoft.PowerShell.EditorServices.Protocol.LanguageServer;
 using Microsoft.PowerShell.EditorServices.Protocol.MessageProtocol;
 using Microsoft.PowerShell.EditorServices.Protocol.MessageProtocol.Channel;
+using Microsoft.PowerShell.EditorServices.Session;
 using Microsoft.PowerShell.EditorServices.Utility;
 using System;
 using System.Collections.Generic;
@@ -23,18 +24,27 @@ public class LanguageServer : LanguageServerBase
     {
         private static CancellationTokenSource existingRequestCancellation;
 
+        private bool profilesLoaded;
         private EditorSession editorSession;
         private OutputDebouncer outputDebouncer;
         private LanguageServerSettings currentSettings = new LanguageServerSettings();
 
-        public LanguageServer() : this(new StdioServerChannel())
+        /// <param name="hostDetails">
+        /// Provides details about the host application.
+        /// </param>
+        public LanguageServer(HostDetails hostDetails)
+            : this(hostDetails, new StdioServerChannel())
         {
         }
 
-        public LanguageServer(ChannelBase serverChannel) : base(serverChannel)
+        /// <param name="hostDetails">
+        /// Provides details about the host application.
+        /// </param>
+        public LanguageServer(HostDetails hostDetails, ChannelBase serverChannel)
+            : base(serverChannel)
         {
             this.editorSession = new EditorSession();
-            this.editorSession.StartSession();
+            this.editorSession.StartSession(hostDetails);
             this.editorSession.ConsoleService.OutputWritten += this.powerShellContext_OutputWritten;
 
             // Always send console prompts through the UI in the language service
@@ -58,7 +68,7 @@ protected override void Initialize()
             this.SetEventHandler(DidOpenTextDocumentNotification.Type, this.HandleDidOpenTextDocumentNotification);
             this.SetEventHandler(DidCloseTextDocumentNotification.Type, this.HandleDidCloseTextDocumentNotification);
             this.SetEventHandler(DidChangeTextDocumentNotification.Type, this.HandleDidChangeTextDocumentNotification);
-            this.SetEventHandler(DidChangeConfigurationNotification<SettingsWrapper>.Type, this.HandleDidChangeConfigurationNotification);
+            this.SetEventHandler(DidChangeConfigurationNotification<LanguageServerSettingsWrapper>.Type, this.HandleDidChangeConfigurationNotification);
 
             this.SetRequestHandler(DefinitionRequest.Type, this.HandleDefinitionRequest);
             this.SetRequestHandler(ReferencesRequest.Type, this.HandleReferencesRequest);
@@ -286,20 +296,29 @@ protected Task HandleDidChangeTextDocumentNotification(
         }
 
         protected async Task HandleDidChangeConfigurationNotification(
-            DidChangeConfigurationParams<SettingsWrapper> configChangeParams,
+            DidChangeConfigurationParams<LanguageServerSettingsWrapper> configChangeParams,
             EventContext eventContext)
         {
-            bool oldScriptAnalysisEnabled =
+            bool oldLoadProfiles = this.currentSettings.EnableProfileLoading;
+            bool oldScriptAnalysisEnabled = 
                 this.currentSettings.ScriptAnalysis.Enable.HasValue;
             string oldScriptAnalysisSettingsPath =
                 this.currentSettings.ScriptAnalysis.SettingsPath;
 
             this.currentSettings.Update(
-                configChangeParams.Settings.Powershell);
+                configChangeParams.Settings.Powershell, 
+                this.editorSession.Workspace.WorkspacePath);
+
+            if (!this.profilesLoaded &&
+                this.currentSettings.EnableProfileLoading &&
+                oldLoadProfiles != this.currentSettings.EnableProfileLoading)
+            {
+                await this.editorSession.PowerShellContext.LoadHostProfiles();
+                this.profilesLoaded = true;
+            }
 
-            string newSettingsPath = this.currentSettings.ScriptAnalysis.SettingsPath;
-            
             // If there is a new settings file path, restart the analyzer with the new settigs.
+            string newSettingsPath = this.currentSettings.ScriptAnalysis.SettingsPath;
             if (!(oldScriptAnalysisSettingsPath?.Equals(newSettingsPath, StringComparison.OrdinalIgnoreCase) ?? false))
             {
                 this.editorSession.RestartAnalysisService(newSettingsPath);
@@ -1000,7 +1019,6 @@ private static CompletionItem CreateCompletionItem(
         {
             string detailString = null;
             string documentationString = null;
-            string labelString = completionDetails.ListItemText;
 
             if ((completionDetails.CompletionType == CompletionType.Variable) ||
                 (completionDetails.CompletionType == CompletionType.ParameterName))
@@ -1013,11 +1031,6 @@ private static CompletionItem CreateCompletionItem(
                 {
                     detailString = matches[0].Groups[1].Value;
                 }
-
-                // PowerShell returns ListItemText for parameters & variables that is not prefixed
-                // and it needs to be or the completion will not appear for these CompletionTypes.
-                string prefix = (completionDetails.CompletionType == CompletionType.Variable) ? "$" : "-";
-                labelString = prefix + completionDetails.ListItemText;
             }
             else if ((completionDetails.CompletionType == CompletionType.Method) ||
                      (completionDetails.CompletionType == CompletionType.Property))
@@ -1054,13 +1067,13 @@ private static CompletionItem CreateCompletionItem(
             // completion list. Technically we don't need the ListItemText at all but it may come
             // in handy during debug.
             var sortText = (completionDetails.CompletionType == CompletionType.ParameterName)
-                  ? string.Format("{0:D3}{1}", sortIndex, completionDetails.ListItemText)
-                  : null;
+                ? $"{sortIndex:D3}{completionDetails.ListItemText}"
+                : null;
 
             return new CompletionItem
             {
                 InsertText = completionDetails.CompletionText,
-                Label = labelString,
+                Label = completionDetails.ListItemText,
                 Kind = MapCompletionKind(completionDetails.CompletionType),
                 Detail = detailString,
                 Documentation = documentationString,

src/PowerShellEditorServices.Protocol/Server/LanguageServerSettings.cs

@@ -3,22 +3,28 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 //
 
+using System.IO;
+using Microsoft.PowerShell.EditorServices.Utility;
+
 namespace Microsoft.PowerShell.EditorServices.Protocol.Server
 {
     public class LanguageServerSettings
     {
+        public bool EnableProfileLoading { get; set; }
+
         public ScriptAnalysisSettings ScriptAnalysis { get; set; }
 
         public LanguageServerSettings()
         {
             this.ScriptAnalysis = new ScriptAnalysisSettings();
         }
 
-        public void Update(LanguageServerSettings settings)
+        public void Update(LanguageServerSettings settings, string workspaceRootPath)
         {
             if (settings != null)
             {
-                this.ScriptAnalysis.Update(settings.ScriptAnalysis);
+                this.EnableProfileLoading = settings.EnableProfileLoading;
+                this.ScriptAnalysis.Update(settings.ScriptAnalysis, workspaceRootPath);
             }
         }
     }
@@ -34,17 +40,31 @@ public ScriptAnalysisSettings()
             this.Enable = true;
         }
 
-        public void Update(ScriptAnalysisSettings settings)
+        public void Update(ScriptAnalysisSettings settings, string workspaceRootPath)
         {
             if (settings != null)
             {
+                Validate.IsNotNullOrEmptyString(nameof(workspaceRootPath), workspaceRootPath);
+
                 this.Enable = settings.Enable;
-                this.SettingsPath = settings.SettingsPath;
+
+                string settingsPath = settings.SettingsPath;
+
+                if (string.IsNullOrWhiteSpace(settingsPath))
+                {
+                    settingsPath = null;
+                }
+                else if (!Path.IsPathRooted(settingsPath))
+                {
+                    settingsPath = Path.GetFullPath(Path.Combine(workspaceRootPath, settingsPath));
+                }
+
+                this.SettingsPath = settingsPath;
             }
         }
     }
 
-    public class SettingsWrapper
+    public class LanguageServerSettingsWrapper
     {
         // NOTE: This property is capitalized as 'Powershell' because the
         // mode name sent from the client is written as 'powershell' and