Make AnalysisService.GetPSSASettingsHashtable static

Author: Kapil Borle

src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs

@@ -309,7 +309,7 @@ private async Task HandleScriptFileMarkersRequest(
         {
             var markers = await editorSession.AnalysisService.GetSemanticMarkersAsync(
                 editorSession.Workspace.GetFile(requestParams.fileUri),
-                editorSession.AnalysisService.GetPSSASettingsHashtable(requestParams.settings));
+                AnalysisService.GetPSSASettingsHashtable(requestParams.settings));
             await requestContext.SendResult(new ScriptFileMarkerRequestResultParams
             {
                 markers = markers
@@ -1097,7 +1097,7 @@ protected async Task HandleCommentHelpRequest(
                 ruleSettings.Add("VSCodeSnippetCorrection", true);
                 ruleSettings.Add("Placement", "before");
                 settings.Add("PSProvideCommentHelp", ruleSettings);
-                var pssaSettings = EditorSession.AnalysisService.GetPSSASettingsHashtable(settings);
+                var pssaSettings = AnalysisService.GetPSSASettingsHashtable(settings);
 
                 // todo create a semantic marker api that take only string
                 var analysisResults = await EditorSession.AnalysisService.GetSemanticMarkersAsync(

src/PowerShellEditorServices/Analysis/AnalysisService.cs

@@ -186,7 +186,7 @@ public IEnumerable<string> GetPSScriptAnalyzerRules()
         /// </summary>
         /// <param name="ruleSettingsMap">A settings hashtable</param>
         /// <returns></returns>
-        public Hashtable GetPSSASettingsHashtable(IDictionary<string, Hashtable> ruleSettingsMap)
+        public static Hashtable GetPSSASettingsHashtable(IDictionary<string, Hashtable> ruleSettingsMap)
         {
             var hashtable = new Hashtable();
             var ruleSettingsHashtable = new Hashtable();