Move PowerShellContext creation out of EditorSession

This change moves the creation of PowerShellContext instances outside of
the EditorSession class so that runspace creation and configuration can
be managed at the host layer.

Author: daviwil

src/PowerShellEditorServices.Host/EditorServicesHost.cs

@@ -271,7 +271,9 @@ private EditorSession CreateSession(
             bool enableConsoleRepl)
         {
             EditorSession editorSession = new EditorSession();
-            editorSession.StartSession(hostDetails, profilePaths, enableConsoleRepl);
+            editorSession.StartSession(
+                CreatePowerShellContext(hostDetails, profilePaths, enableConsoleRepl),
+                enableConsoleRepl);
 
             return editorSession;
         }
@@ -282,11 +284,21 @@ private EditorSession CreateDebugSession(
             IEditorOperations editorOperations)
         {
             EditorSession editorSession = new EditorSession();
-            editorSession.StartDebugSession(hostDetails, profilePaths, editorOperations);
+            editorSession.StartDebugSession(
+                CreatePowerShellContext(hostDetails, profilePaths, enableConsoleRepl),
+                editorOperations);
 
             return editorSession;
         }
 
+        private PowerShellContext CreatePowerShellContext(
+            HostDetails hostDetails,
+            ProfilePaths profilePaths,
+            bool enableConsoleRepl)
+        {
+            return new PowerShellContext(hostDetails, profilePaths, enableConsoleRepl);
+        }
+
 #if !CoreCLR
         static void CurrentDomain_UnhandledException(
             object sender,

src/PowerShellEditorServices/Session/EditorSession.cs

@@ -79,22 +79,15 @@ public class EditorSession
         /// Starts the session using the provided IConsoleHost implementation
         /// for the ConsoleService.
         /// </summary>
-        /// <param name="hostDetails">
-        /// Provides details about the host application.
-        /// </param>
-        /// <param name="profilePaths">
-        /// An object containing the profile paths for the session.
-        /// </param>
         /// <param name="enableConsoleRepl">
         /// Enables a terminal-based REPL for this session.
         /// </param>
         public void StartSession(
-            HostDetails hostDetails,
-            ProfilePaths profilePaths,
+            PowerShellContext powerShellContext,
             bool enableConsoleRepl)
         {
             // Initialize all services
-            this.PowerShellContext = new PowerShellContext(hostDetails, profilePaths, enableConsoleRepl);
+            this.PowerShellContext = powerShellContext;
             this.LanguageService = new LanguageService(this.PowerShellContext);
             this.ConsoleService = new ConsoleService(this.PowerShellContext);
             this.ExtensionService = new ExtensionService(this.PowerShellContext);
@@ -111,22 +104,15 @@ public void StartSession(
         /// Starts a debug-only session using the provided IConsoleHost implementation
         /// for the ConsoleService.
         /// </summary>
-        /// <param name="hostDetails">
-        /// Provides details about the host application.
-        /// </param>
-        /// <param name="profilePaths">
-        /// An object containing the profile paths for the session.
-        /// </param>
         /// <param name="editorOperations">
         /// An IEditorOperations implementation used to interact with the editor.
         /// </param>
         public void StartDebugSession(
-            HostDetails hostDetails,
-            ProfilePaths profilePaths,
+            PowerShellContext powerShellContext,
             IEditorOperations editorOperations)
         {
             // Initialize all services
-            this.PowerShellContext = new PowerShellContext(hostDetails, profilePaths);
+            this.PowerShellContext = powerShellContext;
             this.ConsoleService = new ConsoleService(this.PowerShellContext);
             this.RemoteFileManager = new RemoteFileManager(this.PowerShellContext, editorOperations);
             this.DebugService = new DebugService(this.PowerShellContext, this.RemoteFileManager);