Remove runspace lock from analysisservice

Author: Kapil Borle

src/PowerShellEditorServices/Analysis/AnalysisService.cs

@@ -27,7 +27,6 @@ public class AnalysisService : IDisposable
 
         private Runspace analysisRunspace;
         private PSModuleInfo scriptAnalyzerModuleInfo;
-        private Object runspaceLock;
         private string[] activeRules;
         private string settingsPath;
 
@@ -67,10 +66,7 @@ public string[] ActiveRules
 
             set
             {
-                lock (runspaceLock)
-                {
-                    activeRules = value;
-                }
+                activeRules = value;
             }
         }
 
@@ -86,10 +82,7 @@ public string SettingsPath
             }
             set
             {
-                lock (runspaceLock)
-                {
-                    settingsPath = value;
-                }
+                settingsPath = value;
             }
         }
 
@@ -107,7 +100,6 @@ public AnalysisService(IConsoleHost consoleHost, string settingsPath = null)
         {
             try
             {
-                this.runspaceLock = new Object();
                 this.SettingsPath = settingsPath;
                 this.analysisRunspace = RunspaceFactory.CreateRunspace(InitialSessionState.CreateDefault2());
                 this.analysisRunspace.ThreadOptions = PSThreadOptions.ReuseThread;