Skip tests which depend on help system and so are flaky on Linux

Author: andyleejordan

src/PowerShellEditorServices/Utility/VersionUtils.cs

@@ -50,17 +50,17 @@ internal static class VersionUtils
         public static bool IsPS7OrGreater { get; } = PSVersion.Major >= 7;
 
         /// <summary>
-        /// True if we are running in on Windows, false otherwise.
+        /// True if we are running on Windows, false otherwise.
         /// </summary>
         public static bool IsWindows { get; } = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
 
         /// <summary>
-        /// True if we are running in on macOS, false otherwise.
+        /// True if we are running on macOS, false otherwise.
         /// </summary>
         public static bool IsMacOS { get; } = RuntimeInformation.IsOSPlatform(OSPlatform.OSX);
 
         /// <summary>
-        /// True if we are running in on Linux, false otherwise.
+        /// True if we are running on Linux, false otherwise.
         /// </summary>
         public static bool IsLinux { get; } = RuntimeInformation.IsOSPlatform(OSPlatform.Linux);
     }

test/PowerShellEditorServices.Test.E2E/LanguageServerProtocolMessageTests.cs

@@ -9,6 +9,7 @@
 using System.IO;
 using System.Linq;
 using System.Reflection;
+using System.Runtime.InteropServices;
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
@@ -31,6 +32,9 @@ namespace PowerShellEditorServices.Test.E2E
 {
     public class LanguageServerProtocolMessageTests : IClassFixture<LSPTestsFixture>, IDisposable
     {
+        // Borrowed from `VersionUtils` which can't be used here due to an initialization problem.
+        private static bool IsLinux { get; } = RuntimeInformation.IsOSPlatform(OSPlatform.Linux);
+
         private readonly static string s_binDir =
             Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location);
 
@@ -924,9 +928,10 @@ await PsesLanguageClient
         }
 
         [Trait("Category", "LSP")]
-        [Fact]
+        [SkippableFact]
         public async Task CanSendCompletionAndCompletionResolveRequestAsync()
         {
+            Skip.If(IsLinux, "This depends on the help system, which is flaky on Linux.");
             string filePath = NewTestFile("Write-H");
 
             CompletionList completionItems = await PsesLanguageClient.TextDocument.RequestCompletion(
@@ -950,9 +955,10 @@ public async Task CanSendCompletionAndCompletionResolveRequestAsync()
         }
 
         [Trait("Category", "LSP")]
-        [Fact]
+        [SkippableFact]
         public async Task CanSendCompletionResolveWithModulePrefixRequestAsync()
         {
+            Skip.If(IsLinux, "This depends on the help system, which is flaky on Linux.");
             await PsesLanguageClient
                 .SendRequest<EvaluateRequestArguments>(
                     "evaluate",
@@ -985,9 +991,10 @@ await PsesLanguageClient
         }
 
         [Trait("Category", "LSP")]
-        [Fact]
+        [SkippableFact]
         public async Task CanSendHoverRequestAsync()
         {
+            Skip.If(IsLinux, "This depends on the help system, which is flaky on Linux.");
             string filePath = NewTestFile("Write-Host");
 
             Hover hover = await PsesLanguageClient.TextDocument.RequestHover(