Merge pull request #324 from PowerShell/daviwil/fix-323

Fix #323: DSC IntelliSense can cause language service to crash

Author: daviwil

scripts/FetchLatestBuild.ps1

@@ -38,18 +38,13 @@ function Install-BuildPackage($packageName, $extension) {
 	mkdir $binariesToSignPath -Force | Out-Null
 	cp "$packageContentPath\lib\net45\$packageName.$extension" -Force -Destination $binariesToSignPath
 
-    # Don't forget the x86 exe
-    if ($extension -eq "exe") {
-        cp "$packageContentPath\lib\net45\$packageName.x86.$extension" -Force -Destination $binariesToSignPath
-    }
-
 	Write-Output "Extracted package $packageName ($buildVersion)"
 }
 
 # Pull the build packages from AppVeyor
 Install-BuildPackage "Microsoft.PowerShell.EditorServices" "dll"
 Install-BuildPackage "Microsoft.PowerShell.EditorServices.Protocol" "dll"
-Install-BuildPackage "Microsoft.PowerShell.EditorServices.Host" "exe"
+Install-BuildPackage "Microsoft.PowerShell.EditorServices.Host" "dll"
 
 # Open the BinariesToSign folder
 & start $binariesToSignPath

src/PowerShellEditorServices/Language/LanguageService.cs

@@ -102,23 +102,33 @@ await this.powerShellContext.GetRunspaceHandle(
 
             if (commandCompletion != null)
             {
-                CompletionResults completionResults =
-                    CompletionResults.Create(
-                        scriptFile,
-                        commandCompletion);
-
-                // save state of most recent completion
-                mostRecentCompletions = completionResults;
-                mostRecentRequestFile = scriptFile.Id;
-                mostRecentRequestLine = lineNumber;
-                mostRecentRequestOffest = columnNumber;
-
-                return completionResults;
-            }
-            else
-            {
-                return new CompletionResults();
+                try
+                {
+                    CompletionResults completionResults =
+                        CompletionResults.Create(
+                            scriptFile,
+                            commandCompletion);
+
+                    // save state of most recent completion
+                    mostRecentCompletions = completionResults;
+                    mostRecentRequestFile = scriptFile.Id;
+                    mostRecentRequestLine = lineNumber;
+                    mostRecentRequestOffest = columnNumber;
+
+                    return completionResults;
+                }
+                catch(ArgumentException e)
+                {
+                    // Bad completion results could return an invalid
+                    // replacement range, catch that here
+                    Logger.Write(
+                        LogLevel.Error,
+                        $"Caught exception while trying to create CompletionResults:\n\n{e.ToString()}");
+                }
             }
+
+            // If all else fails, return empty results
+            return new CompletionResults();
         }
 
         /// <summary>