Fix property symbols tests

Author: andyleejordan

src/PowerShellEditorServices/Services/Symbols/Visitors/SymbolVisitor.cs

@@ -195,13 +195,13 @@ public override AstVisitAction VisitMemberExpression(MemberExpressionAst memberE
             return AstVisitAction.Continue;
         }
 
-        // TODO: It's too bad we can't get the member's real symbol and reuse its display string.
+        // TODO: It's too bad we can't get the property's real symbol and reuse its display string.
         return _action(new SymbolReference(
             SymbolType.Property,
 #pragma warning disable CS8604 // Possible null reference argument.
-            memberName,
+            "$" + memberName,
 #pragma warning restore CS8604
-            "(method) " + memberName,
+            "(property) " + memberName,
             memberExpressionAst.Member.Extent,
             memberExpressionAst.Extent,
             _file,
@@ -216,6 +216,7 @@ public override AstVisitAction VisitInvokeMemberExpression(InvokeMemberExpressio
             return AstVisitAction.Continue;
         }
 
+        // TODO: It's too bad we can't get the member's real symbol and reuse its display string.
         return _action(new SymbolReference(
             SymbolType.Method,
 #pragma warning disable CS8604 // Possible null reference argument.

test/PowerShellEditorServices.Test/Language/SymbolsServiceTests.cs

@@ -613,25 +613,43 @@ public async Task FindsPropertyDefinition()
         [Fact]
         public async Task FindsReferencesOnProperty()
         {
-            List<SymbolReference> symbols = await GetReferences(FindsReferencesOnTypeSymbolsData.PropertySourceDetails).ConfigureAwait(true);
-            SymbolReference symbol = Assert.Single(symbols);
-            Assert.Equal("SuperClass.SomeProp", symbol.SymbolName);
-            Assert.Equal(SymbolType.Property, symbol.SymbolType);
-            AssertIsRegion(symbol.NameRegion, 17, 10, 17, 19);
-            AssertIsRegion(symbol.ScriptRegion, 17, 5, 17, 19);
-            // TODO: This should also find $o.SomeProp
+            IEnumerable<SymbolReference> symbols = await GetReferences(FindsReferencesOnTypeSymbolsData.PropertySourceDetails).ConfigureAwait(true);
+            Assert.Collection(symbols,
+                (i) =>
+                {
+                    Assert.Equal("$SomeProp", i.SymbolName);
+                    Assert.Equal("[int] $SomeProp", i.DisplayString);
+                    Assert.Equal(SymbolType.Property, i.SymbolType);
+                    Assert.True(i.IsDeclaration);
+                },
+                (i) =>
+                {
+                    Assert.Equal("$SomeProp", i.SymbolName);
+                    Assert.Equal("(property) SomeProp", i.DisplayString);
+                    Assert.Equal(SymbolType.Property, i.SymbolType);
+                    Assert.False(i.IsDeclaration);
+                });
         }
 
         [Fact]
         public void FindsOccurrencesOnProperty()
         {
-            IReadOnlyList<SymbolReference> symbols = GetOccurrences(FindsOccurrencesOnTypeSymbolsData.PropertySourceDetails);
-            SymbolReference symbol = Assert.Single(symbols);
-            Assert.Equal("SuperClass.SomePropWithDefault", symbol.SymbolName);
-            Assert.Equal(SymbolType.Property, symbol.SymbolType);
-            AssertIsRegion(symbol.NameRegion, 15, 13, 15, 33);
-            AssertIsRegion(symbol.ScriptRegion, 15, 5, 15, 61);
-            // TODO: This should also find the $this.SomePropWithDefault reference.
+            IEnumerable<SymbolReference> symbols = GetOccurrences(FindsOccurrencesOnTypeSymbolsData.PropertySourceDetails);
+            Assert.Collection(symbols,
+                (i) =>
+                {
+                    Assert.Equal("$SomePropWithDefault", i.SymbolName);
+                    Assert.Equal("[string] $SomePropWithDefault", i.DisplayString);
+                    Assert.Equal(SymbolType.Property, i.SymbolType);
+                    Assert.True(i.IsDeclaration);
+                },
+                (i) =>
+                {
+                    Assert.Equal("$SomePropWithDefault", i.SymbolName);
+                    Assert.Equal("(property) SomePropWithDefault", i.DisplayString);
+                    Assert.Equal(SymbolType.Property, i.SymbolType);
+                    Assert.False(i.IsDeclaration);
+                });
         }
 
         [Fact]