fixing declaration request bug

Author: Kayla Davis

src/PowerShellEditorServices.Transport.Stdio/Request/DeclarationRequest.cs

@@ -23,12 +23,17 @@ public override void ProcessMessage(
                     scriptFile,
                     this.Arguments.Line,
                     this.Arguments.Offset);
+               
+            GetDefinitionResult definition = null;
+            if (foundSymbol != null)
+            {
+                definition =
+                    editorSession.LanguageService.GetDefinitionOfSymbol(
+                        scriptFile,
+                        foundSymbol,
+                        editorSession.Workspace);
 
-            GetDefinitionResult definition =
-                editorSession.LanguageService.GetDefinitionOfSymbol(
-                    scriptFile,
-                    foundSymbol,
-                    editorSession.Workspace);
+            }
 
             if (definition != null)
             {
@@ -45,6 +50,9 @@ public override void ProcessMessage(
                 messageWriter.WriteMessage(
                     this.PrepareResponse(defResponse));
             }
+
+            messageWriter.WriteMessage(
+                   this.PrepareResponse(DefinitionResponse.Create()));
         }
     }
 }

src/PowerShellEditorServices/Language/FindDeclartionVisitor.cs

@@ -3,6 +3,7 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 //
 
+using System;
 using System.Management.Automation.Language;
 
 namespace Microsoft.PowerShell.EditorServices.Language
@@ -45,7 +46,7 @@ public override AstVisitAction VisitFunctionDefinition(FunctionDefinitionAst fun
             };
 
             if (symbolRef.SymbolType.Equals(SymbolType.Function) &&
-                 nameExtent.Text.Equals(symbolRef.ScriptRegion.Text))
+                 nameExtent.Text.Equals(symbolRef.ScriptRegion.Text, StringComparison.InvariantCultureIgnoreCase))
             {
                 this.FoundDeclartion =
                     new SymbolReference(
@@ -69,7 +70,7 @@ public override AstVisitAction VisitFunctionDefinition(FunctionDefinitionAst fun
         public override AstVisitAction VisitVariableExpression(VariableExpressionAst variableExpressionAst)
         {
             if(symbolRef.SymbolType.Equals(SymbolType.Variable) &&
-                variableExpressionAst.Extent.Text.Equals(symbolRef.SymbolName))
+                variableExpressionAst.Extent.Text.Equals(symbolRef.SymbolName, StringComparison.InvariantCultureIgnoreCase))
             {
                 this.FoundDeclartion =
                     new SymbolReference(

src/PowerShellEditorServices/Language/FindReferencesVisitor.cs

@@ -3,6 +3,7 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 //
 
+using System;
 using System.Collections.Generic;
 using System.Management.Automation.Language;
 
@@ -34,7 +35,7 @@ public override AstVisitAction VisitCommand(CommandAst commandAst)
         {
             Ast commandNameAst = commandAst.CommandElements[0];
             if(symbolRef.SymbolType.Equals(SymbolType.Function) &&
-                commandNameAst.Extent.Text.Equals(symbolRef.ScriptRegion.Text))
+                commandNameAst.Extent.Text.Equals(symbolRef.ScriptRegion.Text, StringComparison.InvariantCultureIgnoreCase))
             {
                 this.FoundReferences.Add(new SymbolReference(
                                         SymbolType.Function,
@@ -65,7 +66,7 @@ public override AstVisitAction VisitFunctionDefinition(FunctionDefinitionAst fun
             };
 
             if (symbolRef.SymbolType.Equals(SymbolType.Function) &&
-                nameExtent.Text.Equals(symbolRef.SymbolName))
+                nameExtent.Text.Equals(symbolRef.SymbolName, StringComparison.InvariantCultureIgnoreCase))
             {
                 this.FoundReferences.Add(new SymbolReference(
                                           SymbolType.Function,
@@ -83,7 +84,7 @@ public override AstVisitAction VisitFunctionDefinition(FunctionDefinitionAst fun
         public override AstVisitAction VisitCommandParameter(CommandParameterAst commandParameterAst)
         {
             if (symbolRef.SymbolType.Equals(SymbolType.Parameter) &&
-                commandParameterAst.Extent.Text.Equals(symbolRef.SymbolName))
+                commandParameterAst.Extent.Text.Equals(symbolRef.SymbolName, StringComparison.InvariantCultureIgnoreCase))
             {
                 this.FoundReferences.Add(new SymbolReference(
                                          SymbolType.Parameter,
@@ -101,7 +102,7 @@ public override AstVisitAction VisitCommandParameter(CommandParameterAst command
         public override AstVisitAction VisitVariableExpression(VariableExpressionAst variableExpressionAst)
         {
             if(symbolRef.SymbolType.Equals(SymbolType.Variable) &&
-                variableExpressionAst.Extent.Text.Equals(symbolRef.SymbolName))
+                variableExpressionAst.Extent.Text.Equals(symbolRef.SymbolName, StringComparison.InvariantCultureIgnoreCase))
             {
                 this.FoundReferences.Add(new SymbolReference(
                                          SymbolType.Variable,