Split SymbolsService tests out and clean-up

andyleejordan · andyleejordan · commit a517aebbe770 · 2022-01-05T17:06:23.000-08:00
diff --git a/test/PowerShellEditorServices.Test.Shared/Definition/FindsDotSourcedFile.cs b/test/PowerShellEditorServices.Test.Shared/Definition/FindsDotSourcedFile.cs
@@ -5,17 +5,16 @@
 
 namespace Microsoft.PowerShell.EditorServices.Test.Shared.Definition
 {
-    public class FindsDotSourcedFile
+    public static class FindsDotSourcedFileData
     {
-        public static readonly ScriptRegion SourceDetails =
-            new ScriptRegion(
-                file: TestUtilities.NormalizePath("References/DotSources.ps1"),
-                text: string.Empty,
-                startLineNumber: 1,
-                startColumnNumber: 3,
-                startOffset: 0,
-                endLineNumber: 0,
-                endColumnNumber: 0,
-                endOffset: 0);
+        public static readonly ScriptRegion SourceDetails = new(
+            file: TestUtilities.NormalizePath("References/DotSources.ps1"),
+            text: string.Empty,
+            startLineNumber: 1,
+            startColumnNumber: 3,
+            startOffset: 0,
+            endLineNumber: 0,
+            endColumnNumber: 0,
+            endOffset: 0);
     }
 }
diff --git a/test/PowerShellEditorServices.Test.Shared/Definition/FindsFunctionDefinition.cs b/test/PowerShellEditorServices.Test.Shared/Definition/FindsFunctionDefinition.cs
@@ -5,17 +5,16 @@
 
 namespace Microsoft.PowerShell.EditorServices.Test.Shared.Definition
 {
-    public class FindsFunctionDefinition
+    public static class FindsFunctionDefinitionData
     {
-        public static readonly ScriptRegion SourceDetails =
-            new ScriptRegion(
-                file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
-                text: string.Empty,
-                startLineNumber: 3,
-                startColumnNumber: 12,
-                startOffset: 0,
-                endLineNumber: 0,
-                endColumnNumber: 0,
-                endOffset: 0);
+        public static readonly ScriptRegion SourceDetails = new(
+            file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
+            text: string.Empty,
+            startLineNumber: 3,
+            startColumnNumber: 12,
+            startOffset: 0,
+            endLineNumber: 0,
+            endColumnNumber: 0,
+            endOffset: 0);
     }
 }
diff --git a/test/PowerShellEditorServices.Test.Shared/Definition/FindsFunctionDefinitionInDotSourceReference.cs b/test/PowerShellEditorServices.Test.Shared/Definition/FindsFunctionDefinitionInDotSourceReference.cs
@@ -5,17 +5,16 @@
 
 namespace Microsoft.PowerShell.EditorServices.Test.Shared.Definition
 {
-    public class FindsFunctionDefinitionInDotSourceReference
+    public static class FindsFunctionDefinitionInDotSourceReferenceData
     {
-        public static readonly ScriptRegion SourceDetails =
-            new ScriptRegion(
-                file: TestUtilities.NormalizePath("References/FileWithReferences.ps1"),
-                text: string.Empty,
-                startLineNumber: 3,
-                startColumnNumber: 6,
-                startOffset: 0,
-                endLineNumber: 0,
-                endColumnNumber: 0,
-                endOffset: 0);
+        public static readonly ScriptRegion SourceDetails = new(
+            file: TestUtilities.NormalizePath("References/FileWithReferences.ps1"),
+            text: string.Empty,
+            startLineNumber: 3,
+            startColumnNumber: 6,
+            startOffset: 0,
+            endLineNumber: 0,
+            endColumnNumber: 0,
+            endOffset: 0);
     }
 }
diff --git a/test/PowerShellEditorServices.Test.Shared/Definition/FindsFunctionDefinitionInWorkspace.cs b/test/PowerShellEditorServices.Test.Shared/Definition/FindsFunctionDefinitionInWorkspace.cs
@@ -5,17 +5,16 @@
 
 namespace Microsoft.PowerShell.EditorServices.Test.Shared.Definition
 {
-    public class FindsFunctionDefinitionInWorkspace
+    public static class FindsFunctionDefinitionInWorkspaceData
     {
-        public static readonly ScriptRegion SourceDetails =
-            new ScriptRegion(
-                file: TestUtilities.NormalizePath("References/ReferenceFileD.ps1"),
-                text: string.Empty,
-                startLineNumber: 1,
-                startColumnNumber: 2,
-                startOffset: 0,
-                endLineNumber: 0,
-                endColumnNumber: 0,
-                endOffset: 0);
+        public static readonly ScriptRegion SourceDetails = new(
+            file: TestUtilities.NormalizePath("References/ReferenceFileD.ps1"),
+            text: string.Empty,
+            startLineNumber: 1,
+            startColumnNumber: 2,
+            startOffset: 0,
+            endLineNumber: 0,
+            endColumnNumber: 0,
+            endOffset: 0);
     }
 }
diff --git a/test/PowerShellEditorServices.Test.Shared/Definition/FindsVariableDefinition.cs b/test/PowerShellEditorServices.Test.Shared/Definition/FindsVariableDefinition.cs
@@ -5,17 +5,16 @@
 
 namespace Microsoft.PowerShell.EditorServices.Test.Shared.Definition
 {
-    public class FindsVariableDefinition
+    public static class FindsVariableDefinitionData
     {
-        public static readonly ScriptRegion SourceDetails =
-            new ScriptRegion(
-                file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
-                text: string.Empty,
-                startLineNumber: 8,
-                startColumnNumber: 3,
-                startOffset: 0,
-                endLineNumber: 0,
-                endColumnNumber: 0,
-                endOffset: 0);
+        public static readonly ScriptRegion SourceDetails = new(
+            file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
+            text: string.Empty,
+            startLineNumber: 8,
+            startColumnNumber: 3,
+            startOffset: 0,
+            endLineNumber: 0,
+            endColumnNumber: 0,
+            endOffset: 0);
     }
 }
diff --git a/test/PowerShellEditorServices.Test.Shared/Occurrences/FindOccurrencesOnParameter.cs b/test/PowerShellEditorServices.Test.Shared/Occurrences/FindOccurrencesOnParameter.cs
@@ -5,17 +5,16 @@
 
 namespace Microsoft.PowerShell.EditorServices.Test.Shared.Occurrences
 {
-    public class FindOccurrencesOnParameter
+    public static class FindOccurrencesOnParameterData
     {
-        public static readonly ScriptRegion SourceDetails =
-            new ScriptRegion(
-                file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
-                text: string.Empty,
-                startLineNumber: 1,
-                startColumnNumber: 31,
-                startOffset: 0,
-                endLineNumber: 0,
-                endColumnNumber: 0,
-                endOffset: 0);
+        public static readonly ScriptRegion SourceDetails = new(
+            file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
+            text: string.Empty,
+            startLineNumber: 1,
+            startColumnNumber: 31,
+            startOffset: 0,
+            endLineNumber: 0,
+            endColumnNumber: 0,
+            endOffset: 0);
     }
 }
diff --git a/test/PowerShellEditorServices.Test.Shared/Occurrences/FindsOccurrencesOnFunction.cs b/test/PowerShellEditorServices.Test.Shared/Occurrences/FindsOccurrencesOnFunction.cs
@@ -5,17 +5,16 @@
 
 namespace Microsoft.PowerShell.EditorServices.Test.Shared.Occurrences
 {
-    public class FindsOccurrencesOnFunction
+    public static class FindsOccurrencesOnFunctionData
     {
-        public static readonly ScriptRegion SourceDetails =
-            new ScriptRegion(
-                file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
-                text: string.Empty,
-                startLineNumber: 1,
-                startColumnNumber: 17,
-                startOffset: 0,
-                endLineNumber: 0,
-                endColumnNumber: 0,
-                endOffset: 0);
+        public static readonly ScriptRegion SourceDetails = new(
+            file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
+            text: string.Empty,
+            startLineNumber: 1,
+            startColumnNumber: 17,
+            startOffset: 0,
+            endLineNumber: 0,
+            endColumnNumber: 0,
+            endOffset: 0);
     }
 }
diff --git a/test/PowerShellEditorServices.Test.Shared/ParameterHints/FindsParameterSetsOnCommand.cs b/test/PowerShellEditorServices.Test.Shared/ParameterHints/FindsParameterSetsOnCommand.cs
@@ -5,17 +5,16 @@
 
 namespace Microsoft.PowerShell.EditorServices.Test.Shared.ParameterHint
 {
-    public class FindsParameterSetsOnCommand
+    public static class FindsParameterSetsOnCommandData
     {
-        public static readonly ScriptRegion SourceDetails =
-            new ScriptRegion(
-                file: TestUtilities.NormalizePath("ParameterHints/ParamHints.ps1"),
-                text: string.Empty,
-                startLineNumber: 1,
-                startColumnNumber: 14,
-                startOffset: 0,
-                endLineNumber: 0,
-                endColumnNumber: 0,
-                endOffset: 0);
+        public static readonly ScriptRegion SourceDetails = new(
+            file: TestUtilities.NormalizePath("ParameterHints/ParamHints.ps1"),
+            text: string.Empty,
+            startLineNumber: 1,
+            startColumnNumber: 14,
+            startOffset: 0,
+            endLineNumber: 0,
+            endColumnNumber: 0,
+            endOffset: 0);
     }
 }
diff --git a/test/PowerShellEditorServices.Test.Shared/ParameterHints/FindsParameterSetsOnCommandWithSpaces.cs b/test/PowerShellEditorServices.Test.Shared/ParameterHints/FindsParameterSetsOnCommandWithSpaces.cs
@@ -5,17 +5,16 @@
 
 namespace Microsoft.PowerShell.EditorServices.Test.Shared.ParameterHint
 {
-    public class FindsParameterSetsOnCommandWithSpaces
+    public static class FindsParameterSetsOnCommandWithSpacesData
     {
-        public static readonly ScriptRegion SourceDetails =
-            new ScriptRegion(
-                file: TestUtilities.NormalizePath("ParameterHints/ParamHints.ps1"),
-                text: string.Empty,
-                startLineNumber: 9,
-                startColumnNumber: 31,
-                startOffset: 0,
-                endLineNumber: 0,
-                endColumnNumber: 0,
-                endOffset: 0);
+        public static readonly ScriptRegion SourceDetails = new(
+            file: TestUtilities.NormalizePath("ParameterHints/ParamHints.ps1"),
+            text: string.Empty,
+            startLineNumber: 9,
+            startColumnNumber: 31,
+            startOffset: 0,
+            endLineNumber: 0,
+            endColumnNumber: 0,
+            endOffset: 0);
     }
 }
diff --git a/test/PowerShellEditorServices.Test.Shared/References/FindsReferencesOnBuiltInCommandWithAlias.cs b/test/PowerShellEditorServices.Test.Shared/References/FindsReferencesOnBuiltInCommandWithAlias.cs
@@ -5,31 +5,28 @@
 
 namespace Microsoft.PowerShell.EditorServices.Test.Shared.References
 {
-    public class FindsReferencesOnBuiltInCommandWithAlias
+    public static class FindsReferencesOnBuiltInCommandWithAliasData
     {
-        public static readonly ScriptRegion SourceDetails =
-            new ScriptRegion(
-                file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
-                text: string.Empty,
-                startLineNumber: 14,
-                startColumnNumber: 3,
-                startOffset: 0,
-                endLineNumber: 0,
-                endColumnNumber: 0,
-                endOffset: 0);
+        public static readonly ScriptRegion SourceDetails = new(
+            file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
+            text: string.Empty,
+            startLineNumber: 14,
+            startColumnNumber: 3,
+            startOffset: 0,
+            endLineNumber: 0,
+            endColumnNumber: 0,
+            endOffset: 0);
     }
-    public class FindsReferencesOnBuiltInAlias
+    public static class FindsReferencesOnBuiltInAliasData
     {
-        public static readonly ScriptRegion SourceDetails =
-            new ScriptRegion(
-                file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
-                text: string.Empty,
-                startLineNumber: 15,
-                startColumnNumber: 2,
-                startOffset: 0,
-                endLineNumber: 0,
-                endColumnNumber: 0,
-                endOffset: 0);
+        public static readonly ScriptRegion SourceDetails = new(
+            file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
+            text: string.Empty,
+            startLineNumber: 15,
+            startColumnNumber: 2,
+            startOffset: 0,
+            endLineNumber: 0,
+            endColumnNumber: 0,
+            endOffset: 0);
     }
 }
-
diff --git a/test/PowerShellEditorServices.Test.Shared/References/FindsReferencesOnFunctionMultiFileDotSource.cs b/test/PowerShellEditorServices.Test.Shared/References/FindsReferencesOnFunctionMultiFileDotSource.cs
@@ -5,31 +5,29 @@
 
 namespace Microsoft.PowerShell.EditorServices.Test.Shared.References
 {
-    public class FindsReferencesOnFunctionMultiFileDotSourceFileB
+    public static class FindsReferencesOnFunctionMultiFileDotSourceFileB
     {
-        public static readonly ScriptRegion SourceDetails =
-            new ScriptRegion(
-                file: TestUtilities.NormalizePath("References/ReferenceFileB.ps1"),
-                text: string.Empty,
-                startLineNumber: 5,
-                startColumnNumber: 8,
-                startOffset: 0,
-                endLineNumber: 0,
-                endColumnNumber: 0,
-                endOffset: 0);
+        public static readonly ScriptRegion SourceDetails = new(
+            file: TestUtilities.NormalizePath("References/ReferenceFileB.ps1"),
+            text: string.Empty,
+            startLineNumber: 5,
+            startColumnNumber: 8,
+            startOffset: 0,
+            endLineNumber: 0,
+            endColumnNumber: 0,
+            endOffset: 0);
     }
-    public class FindsReferencesOnFunctionMultiFileDotSourceFileC
+
+    public static class FindsReferencesOnFunctionMultiFileDotSourceFileC
     {
-        public static readonly ScriptRegion SourceDetails =
-            new ScriptRegion(
-                file: TestUtilities.NormalizePath("References/ReferenceFileC.ps1"),
-                text: string.Empty,
-                startLineNumber: 4,
-                startColumnNumber: 10,
-                startOffset: 0,
-                endLineNumber: 0,
-                endColumnNumber: 0,
-                endOffset: 0);
+        public static readonly ScriptRegion SourceDetails = new(
+            file: TestUtilities.NormalizePath("References/ReferenceFileC.ps1"),
+            text: string.Empty,
+            startLineNumber: 4,
+            startColumnNumber: 10,
+            startOffset: 0,
+            endLineNumber: 0,
+            endColumnNumber: 0,
+            endOffset: 0);
     }
 }
-
diff --git a/test/PowerShellEditorServices.Test.Shared/SymbolDetails/FindsDetailsForBuiltInCommand.cs b/test/PowerShellEditorServices.Test.Shared/SymbolDetails/FindsDetailsForBuiltInCommand.cs
@@ -5,17 +5,16 @@
 
 namespace Microsoft.PowerShell.EditorServices.Test.Shared.SymbolDetails
 {
-    public class FindsDetailsForBuiltInCommand
+    public static class FindsDetailsForBuiltInCommandData
     {
-        public static readonly ScriptRegion SourceDetails =
-            new ScriptRegion(
-                file: TestUtilities.NormalizePath("SymbolDetails/SymbolDetails.ps1"),
-                text: string.Empty,
-                startLineNumber: 1,
-                startColumnNumber: 10,
-                startOffset: 0,
-                endLineNumber: 0,
-                endColumnNumber: 0,
-                endOffset: 0);
+        public static readonly ScriptRegion SourceDetails = new(
+            file: TestUtilities.NormalizePath("SymbolDetails/SymbolDetails.ps1"),
+            text: string.Empty,
+            startLineNumber: 1,
+            startColumnNumber: 10,
+            startOffset: 0,
+            endLineNumber: 0,
+            endColumnNumber: 0,
+            endOffset: 0);
     }
 }
diff --git a/test/PowerShellEditorServices.Test/Language/LanguageServiceTests.cs b/test/PowerShellEditorServices.Test/Language/LanguageServiceTests.cs
diff --git a/test/PowerShellEditorServices.Test/Language/SymbolsServiceTests.cs b/test/PowerShellEditorServices.Test/Language/SymbolsServiceTests.cs
