Added a new test case for renaming an inner variable leaking out the functions scope

Author: Razmo99

src/PowerShellEditorServices/Services/PowerShell/Refactoring/IterativeVariableVisitor.cs

@@ -322,6 +322,13 @@ private void ProcessVariableExpressionAst(VariableExpressionAst variableExpressi
                     {
                         ShouldRename = true;
                     }
+                    // The TargetVariable is defined within a function
+                    // This commandAst is not within that function's scope so we should not rename
+                    if (GetAstParentScope(TargetVariableAst) is FunctionDefinitionAst && !WithinTargetsScope(TargetVariableAst, commandAst))
+                    {
+                        ShouldRename = false;
+                    }
+
                 }
                 // Is this a Variable Assignment thats not within scope
                 else if (variableExpressionAst.Parent is AssignmentStatementAst assignment &&

test/PowerShellEditorServices.Test.Shared/Refactoring/Variables/RefactorVariablesData.cs

@@ -163,5 +163,12 @@ internal static class RenameVariableData
             Line = 9,
             RenameTo = "Renamed"
         };
+        public static readonly RenameSymbolParams VariableNestedScopeFunctionRefactorInner = new()
+        {
+            FileName = "VariableNestedScopeFunctionRefactorInner.ps1",
+            Column = 5,
+            Line = 3,
+            RenameTo = "Renamed"
+        };
     }
 }

test/PowerShellEditorServices.Test.Shared/Refactoring/Variables/VariableNestedScopeFunctionRefactorInner.ps1

@@ -0,0 +1,7 @@
+$var = 10
+function TestFunction {
+    $var = 20
+    Write-Output $var
+}
+TestFunction
+Write-Output $var

test/PowerShellEditorServices.Test.Shared/Refactoring/Variables/VariableNestedScopeFunctionRefactorInnerRenamed.ps1

@@ -0,0 +1,7 @@
+$var = 10
+function TestFunction {
+    $Renamed = 20
+    Write-Output $Renamed
+}
+TestFunction
+Write-Output $var

test/PowerShellEditorServices.Test/Refactoring/RefactorVariableTests.cs

@@ -71,6 +71,7 @@ public VariableRenameTestData()
                 Add(new RenameSymbolParamsSerialized(RenameVariableData.VariableCommandParameterSplattedFromSplat));
                 Add(new RenameSymbolParamsSerialized(RenameVariableData.VariableInForeachDuplicateAssignment));
                 Add(new RenameSymbolParamsSerialized(RenameVariableData.VariableInForloopDuplicateAssignment));
+                Add(new RenameSymbolParamsSerialized(RenameVariableData.VariableNestedScopeFunctionRefactorInner));
             }
         }