Added test case for simple function parameter rename, added clause for is target is within a parameter block within a function to solve

Author: Razmo99

src/PowerShellEditorServices/Services/PowerShell/Refactoring/IterativeVariableVisitor.cs

@@ -82,6 +82,15 @@ public static Ast GetVariableTopAssignment(int StartLineNumber, int StartColumnN
             }
 
             Ast TargetParent = GetAstParentScope(node);
+
+            // Is the Variable sitting within a ParameterBlockAst that is within a Function Definition
+            // If so we don't need to look further as this is most likley the AssignmentStatement we are looking for
+            Ast paramParent = Utilities.GetAstParentOfType(node, typeof(ParamBlockAst));
+            if (TargetParent is FunctionDefinitionAst && null != paramParent)
+            {
+                return node;
+            }
+
             // Find all variables and parameter assignments with the same name before
             // The node found above
             List<VariableExpressionAst> VariableAssignments = ScriptAst.FindAll(ast =>

test/PowerShellEditorServices.Test.Shared/Refactoring/Variables/RefactorVariablesData.cs

@@ -170,5 +170,12 @@ internal static class RenameVariableData
             Line = 3,
             RenameTo = "Renamed"
         };
+        public static readonly RenameSymbolParams VariableSimpleFunctionParameter = new()
+        {
+            FileName = "VariableSimpleFunctionParameter.ps1",
+            Column = 9,
+            Line = 6,
+            RenameTo = "Renamed"
+        };
     }
 }

test/PowerShellEditorServices.Test.Shared/Refactoring/Variables/VariableSimpleFunctionParameter.ps1

@@ -0,0 +1,18 @@
+$x = 1..10
+
+function testing_files {
+
+    param (
+        $x
+    )
+    write-host "Printing $x"
+}
+
+foreach ($number in $x) {
+    testing_files $number
+
+    function testing_files {
+        write-host "------------------"
+    }
+}
+testing_files "99"

test/PowerShellEditorServices.Test.Shared/Refactoring/Variables/VariableSimpleFunctionParameterRenamed.ps1

@@ -0,0 +1,18 @@
+$x = 1..10
+
+function testing_files {
+
+    param (
+        [Alias("x")]$Renamed
+    )
+    write-host "Printing $Renamed"
+}
+
+foreach ($number in $x) {
+    testing_files $number
+
+    function testing_files {
+        write-host "------------------"
+    }
+}
+testing_files "99"