Update ScriptFileMarkersRequestParams class

Author: Kapil Borle

src/PowerShellEditorServices.Protocol/LanguageServer/ScriptFileMarkersRequest.cs

@@ -17,7 +17,6 @@ public static readonly
     class ScriptFileMarkerRequestParams
     {
         public string filePath;
-        public string[] rules;
         public string settings;
     }
 

src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs

@@ -239,7 +239,6 @@ private async Task HandleScriptFileMarkersRequest(
         {
             var markers = editorSession.AnalysisService.GetSemanticMarkers(
                 editorSession.Workspace.GetFile(requestParams.filePath),
-                requestParams.rules,
                 editorSession.LanguageService.GetHashtableFromString(requestParams.settings));
             await requestContext.SendResult(new ScriptFileMarkerRequestResultParams {
                 markers = markers

src/PowerShellEditorServices/Analysis/AnalysisService.cs

@@ -139,14 +139,9 @@ public ScriptFileMarker[] GetSemanticMarkers(ScriptFile file)
             return GetSemanticMarkers(file, activeRules, settingsPath);
         }
 
-        public ScriptFileMarker[] GetSemanticMarkers(ScriptFile file, string[] rules, string settingsPath)
+        public ScriptFileMarker[] GetSemanticMarkers(ScriptFile file, Hashtable settings)
         {
-            return GetSemanticMarkers<string>(file, rules, settingsPath);
-        }
-
-        public ScriptFileMarker[] GetSemanticMarkers(ScriptFile file, string[] rules, Hashtable settings)
-        {
-            return GetSemanticMarkers<Hashtable>(file, rules, settings);
+            return GetSemanticMarkers<Hashtable>(file, null, settings);
         }
 
         private ScriptFileMarker[] GetSemanticMarkers<TSettings>(
@@ -156,8 +151,8 @@ private ScriptFileMarker[] GetSemanticMarkers<TSettings>(
         {
             if (this.scriptAnalyzerModuleInfo != null
                 && file.IsAnalysisEnabled
-                && (typeof(TSettings) == typeof(string)
-                    || typeof(TSettings) == typeof(Hashtable)))
+                && (typeof(TSettings) == typeof(string) || typeof(TSettings) == typeof(Hashtable))
+                && (rules != null || settings != null))
             {
                 // TODO: This is a temporary fix until we can change how
                 // ScriptAnalyzer invokes their async tasks.