Merge pull request #108 from rkeithhill/rkeithhill/fix-getvariables-failed

Rkeithhill/fix getvariables failed

Author: daviwil

src/PowerShellEditorServices/Debugging/DebugService.cs

@@ -360,16 +360,19 @@ private async Task<VariableContainerDetails> FetchVariableContainer(
                 new VariableContainerDetails(this.nextVariableId++, "Scope: " + scope);
             this.variables.Add(scopeVariableContainer);
 
-            var results = await this.powerShellContext.ExecuteCommand<PSVariable>(psCommand);
-            foreach (PSVariable psvariable in results)
+            var results = await this.powerShellContext.ExecuteCommand<PSVariable>(psCommand, sendErrorToHost: false);
+            if (results != null)
             {
-                var variableDetails = new VariableDetails(psvariable) { Id = this.nextVariableId++ };
-                this.variables.Add(variableDetails);
-                scopeVariableContainer.Children.Add(variableDetails.Name, variableDetails);
-
-                if ((autoVariables != null) && AddToAutoVariables(psvariable, scope))
+                foreach (PSVariable psvariable in results)
                 {
-                    autoVariables.Children.Add(variableDetails.Name, variableDetails);
+                    var variableDetails = new VariableDetails(psvariable) {Id = this.nextVariableId++};
+                    this.variables.Add(variableDetails);
+                    scopeVariableContainer.Children.Add(variableDetails.Name, variableDetails);
+
+                    if ((autoVariables != null) && AddToAutoVariables(psvariable, scope))
+                    {
+                        autoVariables.Children.Add(variableDetails.Name, variableDetails);
+                    }
                 }
             }
 

src/PowerShellEditorServices/Session/PowerShellContext.cs

@@ -208,13 +208,17 @@ public Task<RunspaceHandle> GetRunspaceHandle()
         /// <param name="sendOutputToHost">
         /// If true, causes any output written during command execution to be written to the host.
         /// </param>
+        /// <param name="sendErrorToHost">
+        /// If true, causes any errors encountered during command execution to be written to the host.
+        /// </param>
         /// <returns>
         /// An awaitable Task which will provide results once the command
         /// execution completes.
         /// </returns>
         public async Task<IEnumerable<TResult>> ExecuteCommand<TResult>(
             PSCommand psCommand,
-            bool sendOutputToHost = false)
+            bool sendOutputToHost = false,
+            bool sendErrorToHost = true)
         {
             RunspaceHandle runspaceHandle = null;
             IEnumerable<TResult> executionResult = null;
@@ -324,8 +328,11 @@ await Task.Factory.StartNew<IEnumerable<TResult>>(
                         LogLevel.Error,
                         "Runtime exception occurred while executing command:\r\n\r\n" + e.ToString());
 
-                    // Write the error to the host
-                    this.WriteExceptionToHost(e);
+                    if (sendErrorToHost)
+                    {
+                        // Write the error to the host
+                        this.WriteExceptionToHost(e);
+                    }
                 }
                 finally
                 {