Count ${Function:My-Function} as a function reference (#1993)

Author: andyleejordan

src/PowerShellEditorServices/Services/Symbols/Visitors/SymbolVisitor.cs

@@ -95,6 +95,21 @@ public override AstVisitAction VisitVariableExpression(VariableExpressionAst var
             return AstVisitAction.Continue;
         }
 
+        // Count $Function:MyFunction as function references.
+        if (variableExpressionAst.VariablePath.IsDriveQualified
+            && variableExpressionAst.VariablePath.DriveName.Equals("Function", StringComparison.OrdinalIgnoreCase))
+        {
+            return _action(new SymbolReference(
+                SymbolType.Function,
+                "fn " + VisitorUtils.GetUnqualifiedVariableName(variableExpressionAst.VariablePath),
+                "$" + variableExpressionAst.VariablePath.UserPath,
+                variableExpressionAst.Extent,
+                variableExpressionAst.Extent,
+                _file,
+                false
+            ));
+        }
+
         // TODO: Consider tracking unscoped variable references only when they're declared within
         // the same function definition.
         return _action(new SymbolReference(

test/PowerShellEditorServices.Test.Shared/References/SimpleFile.ps1

@@ -18,3 +18,5 @@ Write-Host
 Get-ChildItem
 
 My-Alias
+
+Invoke-Command -ScriptBlock ${Function:My-Function}

test/PowerShellEditorServices.Test/Language/SymbolsServiceTests.cs

@@ -223,6 +223,13 @@ public async Task FindsReferencesOnFunction()
                 Assert.Equal("My-Function", i.Name);
                 Assert.Equal(SymbolType.Function, i.Type);
                 Assert.False(i.IsDeclaration);
+            },
+            (i) =>
+            {
+                Assert.Equal("fn My-Function", i.Id);
+                Assert.Equal("$Function:My-Function", i.Name);
+                Assert.Equal(SymbolType.Function, i.Type);
+                Assert.False(i.IsDeclaration);
             });
         }
 
@@ -246,7 +253,8 @@ await psesHost.ExecutePSCommandAsync(
                 {
                     AssertIsRegion(i.NameRegion, 20, 1, 20, 9);
                     Assert.Equal("fn My-Alias", i.Id);
-                });
+                },
+                (i) => AssertIsRegion(i.NameRegion, 22, 29, 22, 52));
         }
 
         [Fact]
@@ -324,6 +332,13 @@ public void FindsOccurrencesOnFunction()
                     Assert.Equal("fn My-Function", i.Id);
                     Assert.Equal(SymbolType.Function, i.Type);
                     Assert.False(i.IsDeclaration);
+                },
+                (i) =>
+                {
+                    Assert.Equal("fn My-Function", i.Id);
+                    Assert.Equal("$Function:My-Function", i.Name);
+                    Assert.Equal(SymbolType.Function, i.Type);
+                    Assert.False(i.IsDeclaration);
                 });
         }