Fix all compiler warnings

Author: daviwil

src/PowerShellEditorServices.Protocol/MessageProtocol/Channel/NamedPipeClientChannel.cs

@@ -12,7 +12,6 @@ namespace Microsoft.PowerShell.EditorServices.Protocol.MessageProtocol.Channel
     public class NamedPipeClientChannel : ChannelBase
     {
         private string pipeName;
-        private bool isClientConnected;
         private NamedPipeClientStream pipeClient;
 
         public NamedPipeClientChannel(string pipeName)

src/PowerShellEditorServices.Protocol/MessageProtocol/MessageDispatcher.cs

@@ -18,7 +18,6 @@ public class MessageDispatcher
         #region Fields
 
         private ChannelBase protocolChannel;
-        private AsyncQueue<Message> messagesToWrite;
         private AsyncContextThread messageLoopThread;
 
         private Dictionary<string, Func<Message, MessageWriter, Task>> requestHandlers =

src/PowerShellEditorServices.Protocol/Server/DebugAdapter.cs

@@ -150,7 +150,9 @@ protected async Task HandleLaunchRequest(
             string workingDir =
                 launchParams.Cwd ??
                 launchParams.Script ??
+#pragma warning disable 618
                 launchParams.Program;
+#pragma warning restore 618
 
             if (workingDir != null)
             {
@@ -192,7 +194,9 @@ protected async Task HandleLaunchRequest(
 
             // Store the launch parameters so that they can be used later
             this.noDebug = launchParams.NoDebug;
+#pragma warning disable 618
             this.scriptPathToLaunch = launchParams.Script ?? launchParams.Program;
+#pragma warning restore 618
             this.arguments = arguments;
 
             await requestContext.SendResult(null);

src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs

@@ -12,7 +12,6 @@
 using Microsoft.PowerShell.EditorServices.Utility;
 using Newtonsoft.Json.Linq;
 using System;
-using System.Collections;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;

src/PowerShellEditorServices.Protocol/Server/LanguageServerBase.cs

@@ -12,9 +12,7 @@ namespace Microsoft.PowerShell.EditorServices.Protocol.Server
 {
     public abstract class LanguageServerBase : ProtocolEndpoint
     {
-        private bool isStarted;
         private ChannelBase serverChannel;
-        private TaskCompletionSource<bool> serverExitedTask;
 
         public LanguageServerBase(ChannelBase serverChannel) : 
             base(serverChannel, MessageProtocolType.LanguageServer)
@@ -72,12 +70,6 @@ private async Task HandleExitNotification(
         {
             // Stop the server channel
             await this.Stop();
-
-            // Notify any waiter that the server has exited
-            if (this.serverExitedTask != null)
-            {
-                this.serverExitedTask.SetResult(true);
-            }
         }
     }
 }

test/PowerShellEditorServices.Test.Host/LanguageServerTests.cs

@@ -168,19 +168,22 @@ await this.SendRequest(
         [Fact(Skip = "Skipped until variable documentation gathering is added back.")]
         public async Task CompletesDetailOnVariableDocSuggestion()
         {
-            //await this.SendOpenFileEvent("TestFiles\\CompleteFunctionName.ps1");
+            await this.SendOpenFileEvent("TestFiles\\CompleteFunctionName.ps1");
 
-            //await this.SendRequest(
-            //    CompletionRequest.Type,
-            //    new TextDocumentPosition
-            //    {
-            //        Uri = "TestFiles\\CompleteFunctionName.ps1",
-            //        Position = new Position
-            //        {
-            //            Line = 7,
-            //            Character = 5
-            //        }
-            //    });
+            await this.SendRequest(
+                CompletionRequest.Type,
+                new TextDocumentPosition
+                {
+                    Uri = "TestFiles\\CompleteFunctionName.ps1",
+                    Position = new Position
+                    {
+                        Line = 7,
+                        Character = 5
+                    }
+                });
+
+            // TODO: This section needs to be updated, seems that
+            // CompletionsResponse is missing.
 
             //CompletionsResponse completion = this.WaitForMessage<CompletionsResponse>();
             //List<string> entryName = new List<string>();

test/PowerShellEditorServices.Test/Debugging/DebugServiceTests.cs

@@ -112,8 +112,9 @@ await this.debugService.SetLineBreakpoints(
             string arguments = string.Join(" ", args);
 
             // Execute the script and wait for the breakpoint to be hit
-            this.powerShellContext.ExecuteScriptAtPath(
-                debugWithParamsFile.FilePath, arguments);
+            Task executeTask =
+                this.powerShellContext.ExecuteScriptAtPath(
+                    debugWithParamsFile.FilePath, arguments);
 
             await this.AssertDebuggerStopped(debugWithParamsFile.FilePath);
 

test/PowerShellEditorServices.Test/Session/PowerShellContextTests.cs

@@ -73,10 +73,10 @@ public async Task CanExecutePSCommand()
         public async Task CanQueueParallelRunspaceRequests()
         {
             // Concurrently initiate 4 requests in the session
-            this.powerShellContext.ExecuteScriptString("$x = 100");
+            Task taskOne = this.powerShellContext.ExecuteScriptString("$x = 100");
             Task<RunspaceHandle> handleTask = this.powerShellContext.GetRunspaceHandle();
-            this.powerShellContext.ExecuteScriptString("$x += 200");
-            this.powerShellContext.ExecuteScriptString("$x = $x / 100");
+            Task taskTwo = this.powerShellContext.ExecuteScriptString("$x += 200");
+            Task taskThree = this.powerShellContext.ExecuteScriptString("$x = $x / 100");
 
             PSCommand psCommand = new PSCommand();
             psCommand.AddScript("$x");
@@ -86,8 +86,11 @@ public async Task CanQueueParallelRunspaceRequests()
             RunspaceHandle handle = await handleTask;
             handle.Dispose();
 
+            // Wait for all of the executes to complete
+            await Task.WhenAll(taskOne, taskTwo, taskThree, resultTask);
+
             // At this point, the remaining command executions should execute and complete
-            int result = (await resultTask).FirstOrDefault();
+            int result = resultTask.Result.FirstOrDefault();
 
             // 100 + 200 = 300, then divided by 100 is 3.  We are ensuring that
             // the commands were executed in the sequence they were called.