Fix DebugService.Abort() deadlock

andyleejordan · andyleejordan · commit 301ee6963413 · 2021-08-11T18:07:28.000-07:00
With the default value of `true` for `shouldWaitForExit` this would
deadlock because it exepcted the pipeline execution thread to clean it
up...except it was waiting in the pipeline execution thread.
diff --git a/src/PowerShellEditorServices/Services/PowerShellContext/PowerShellContextService.cs b/src/PowerShellEditorServices/Services/PowerShellContext/PowerShellContextService.cs
@@ -1248,7 +1248,7 @@ public void AbortExecution(bool shouldAbortDebugSession)
                 this.versionSpecificOperations.StopCommandInDebugger(this);
                 if (shouldAbortDebugSession)
                 {
-                    this.ResumeDebugger(DebuggerResumeAction.Stop);
+                    this.ResumeDebugger(DebuggerResumeAction.Stop, shouldWaitForExit: false);
                 }
             }
             else
@@ -1940,7 +1940,7 @@ private void PowerShellContext_ExecutionStatusChangedAsync(object sender, Execut
 
         private IEnumerable<TResult> ExecuteCommandInDebugger<TResult>(PSCommand psCommand, bool sendOutputToHost)
         {
-            this.logger.LogTrace($"Attempting to execute command(s)a in the debugger: {GetStringForPSCommand(psCommand)}");
+            this.logger.LogTrace($"Attempting to execute command(s) in the debugger: {GetStringForPSCommand(psCommand)}");
 
             IEnumerable<TResult> output =
                 this.versionSpecificOperations.ExecuteCommandInDebugger<TResult>(

Original file line number	Diff line number	Diff line change
`@@ -1248,7 +1248,7 @@ public void AbortExecution(bool shouldAbortDebugSession)`
`1248`	`1248`	`this.versionSpecificOperations.StopCommandInDebugger(this);`
`1249`	`1249`	`if (shouldAbortDebugSession)`
`1250`	`1250`	`{`
`1251`		`- this.ResumeDebugger(DebuggerResumeAction.Stop);`
	`1251`	`+ this.ResumeDebugger(DebuggerResumeAction.Stop, shouldWaitForExit: false);`
`1252`	`1252`	`}`
`1253`	`1253`	`}`
`1254`	`1254`	`else`
`@@ -1940,7 +1940,7 @@ private void PowerShellContext_ExecutionStatusChangedAsync(object sender, Execut`
`1940`	`1940`
`1941`	`1941`	`private IEnumerable<TResult> ExecuteCommandInDebugger<TResult>(PSCommand psCommand, bool sendOutputToHost)`
`1942`	`1942`	`{`
`1943`		`- this.logger.LogTrace($"Attempting to execute command(s)a in the debugger: {GetStringForPSCommand(psCommand)}");`
	`1943`	`+ this.logger.LogTrace($"Attempting to execute command(s) in the debugger: {GetStringForPSCommand(psCommand)}");`
`1944`	`1944`
`1945`	`1945`	`IEnumerable<TResult> output =`
`1946`	`1946`	`this.versionSpecificOperations.ExecuteCommandInDebugger<TResult>(`