Rolyn Lint Fixes

Author: JustinGrote

src/PowerShellEditorServices/Services/PowerShell/Refactoring/Exceptions.cs

@@ -4,7 +4,6 @@
 using System;
 namespace Microsoft.PowerShell.EditorServices.Refactoring
 {
-
     public class TargetSymbolNotFoundException : Exception
     {
         public TargetSymbolNotFoundException()

src/PowerShellEditorServices/Services/TextDocument/Handlers/RenameHandler.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 #nullable enable
 
-
 using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.PowerShell.EditorServices.Services;

src/PowerShellEditorServices/Services/TextDocument/RenameService.cs

@@ -180,8 +180,6 @@ private TextEdit[] RenameVariable(Ast symbol, Ast scriptAst, RenameParams reques
             }
         }
 
-
-
         return ast;
     }
 

src/PowerShellEditorServices/Utility/AstExtensions.cs

@@ -438,7 +438,6 @@ public static bool TryGetFunction(this ParameterAst ast, out FunctionDefinitionA
             {
                 return splatParamReference;
             }
-
         }
 
         // If nothing found, search parent scopes for a variable assignment until we hit the top of the document
@@ -508,7 +507,6 @@ public static bool TryGetFunction(this ParameterAst ast, out FunctionDefinitionA
                     && foundFunction?.Parent?.Parent == scope
                 ),
 
-
                 _ => null
             };
 
@@ -560,7 +558,6 @@ public static bool HasParent(this Ast ast, Ast parent)
         return false;
     }
 
-
     /// <summary>
     /// Return an extent that only contains the position of the name of the function, for Client highlighting purposes.
     /// </summary>

test/PowerShellEditorServices.Test.Shared/Refactoring/Functions/_RefactorFunctionTestCases.cs

@@ -3,7 +3,7 @@
 
 namespace PowerShellEditorServices.Test.Shared.Refactoring;
 
-public class RefactorFunctionTestCases
+public static class RefactorFunctionTestCases
 {
     /// <summary>
     /// Defines where functions should be renamed. These numbers are 1-based.

test/PowerShellEditorServices.Test.Shared/Refactoring/Variables/_RefactorVariableTestCases.cs

@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 namespace PowerShellEditorServices.Test.Shared.Refactoring;
-public class RefactorVariableTestCases
+public static class RefactorVariableTestCases
 {
     public static RenameTestTarget[] TestCases =
     [

test/PowerShellEditorServices.Test/Refactoring/PrepareRenameHandlerTests.cs

@@ -164,8 +164,6 @@ public async Task<TResponse> SendRequest<TResponse>(IRequest<TResponse> request,
     public bool TryGetRequest(long id, out string method, out TaskCompletionSource<JToken> pendingTask) => throw new NotImplementedException();
 }
 
-
-
 public class EmptyConfiguration : ConfigurationRoot, ILanguageServerConfiguration, IScopedConfiguration
 {
     public EmptyConfiguration() : base([]) { }

test/PowerShellEditorServices.Test/Refactoring/RefactorUtilities.cs

@@ -9,7 +9,7 @@
 
 namespace PowerShellEditorServices.Test.Refactoring
 {
-    public class RefactorUtilities
+    public static class RefactorUtilities
     {
         /// <summary>
         /// A simplistic "Mock" implementation of vscode client performing rename activities. It is not comprehensive and an E2E test is recommended.

test/PowerShellEditorServices.Test/Refactoring/RenameHandlerTests.cs

@@ -13,6 +13,7 @@
 using System.Threading;
 using Xunit;
 using PowerShellEditorServices.Test.Shared.Refactoring;
+using System.Threading.Tasks;
 
 namespace PowerShellEditorServices.Test.Handlers;
 #pragma warning disable VSTHRD100 // XUnit handles async void with a custom SyncContext
@@ -53,7 +54,7 @@ public static TheoryData<RenameTestTargetSerializable> FunctionTestCases()
 
     [Theory]
     [MemberData(nameof(FunctionTestCases))]
-    public async void RenamedFunction(RenameTestTarget s)
+    public async Task RenamedFunction(RenameTestTarget s)
     {
         RenameParams request = s.ToRenameParams("Functions");
         WorkspaceEdit response;
@@ -90,7 +91,7 @@ public async void RenamedFunction(RenameTestTarget s)
 
     [Theory]
     [MemberData(nameof(VariableTestCases))]
-    public async void RenamedVariable(RenameTestTarget s)
+    public async Task RenamedVariable(RenameTestTarget s)
     {
         RenameParams request = s.ToRenameParams("Variables");
         WorkspaceEdit response;